feat: Extended the menu/order metadata#18
Draft
radektomasek wants to merge 1 commit intomasterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enrich selections with itemGroup and salesCategory names
Resolves missing human-readable names on the
selectionstable by building in-memory lookup dictionaries from the menus data and injecting them before writing orders to CSV.Changes
component.py: Added_item_group_namesand_sales_category_namesdicts on__init__component.py:download_menusnow populates both lookup dicts frommenus_menuGroupsandmenus_menuGroups_menuItemsparsed outputcomponent.py:download_ordersenriches each record inorders_checks_selectionswithitemGroup_nameandsalesCategory_namebefore writingcomponent.py: Reorderedrun()to calldownload_menusbeforedownload_ordersso lookups are populated in timeparser_mapping.json: AddeditemGroup_nameandsalesCategory_nametoselections.column_mappingsHow to test
menusandordersin theendpointslistselections.csvand verify:itemGroup_nameis populated with the menu group name (e.g."Burgers") and matches theitemGroup_guidsalesCategory_nameis populated (e.g."Food") and matches thesalesCategory_guidmenuGroups.csvandmenuItems.csvfrom the same runitemGroup_guidorsalesCategory_guidis empty/null produce empty strings rather than errors