Skip to content

fix(SUPPORT-14907): improve error logging when page token lookup fails #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devin-ai-integration wants to merge 3 commits into from
Closed

fix(SUPPORT-14907): improve error logging when page token lookup fails #125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6f7cc3
fix(SUPPORT-14907): handle future timestamps in pagination URLs
devin-ai-integration[bot] Jan 12, 2026
907b61b
fix(SUPPORT-14907): log errors when page token lookup fails
devin-ai-integration[bot] Jan 13, 2026
2e84f41
revert: remove future timestamp handling from pagination
devin-ai-integration[bot] Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/keboola/facebook/extractor/query.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,29 @@
all-rows (apply concat nested-data)]
(output/write-rows all-rows out-dir prefix false (incremental? query))))

(defmacro swallow-exceptions [& body]
`(try ~@body (catch Exception e#)))
(defmacro try-with-warning [context & body]
`(try ~@body
(catch Exception e#
(runtime/log-error (str "Warning: " ~context " failed: " (.getMessage e#)))
nil)))

(defn retrieve-page-access-token [id token version]
(let [accounts (swallow-exceptions (request/get-accounts token :version version))
page-token-from-accounts-list (if (some? accounts) (:access_token (first (filter #(= id (:id %)) accounts))))
page-token-from-page-details (swallow-exceptions (request/get-page-token-via-page-details token id))
(let [accounts (try-with-warning (str "fetching accounts list for page " id)
(request/get-accounts token :version version))
page-token-from-accounts-list (when (some? accounts)
(:access_token (first (filter #(= id (:id %)) accounts))))
page-token-from-page-details (when (nil? page-token-from-accounts-list)
(try-with-warning (str "fetching page token via page details for " id)
(request/get-page-token-via-page-details token id)))
page-token (or page-token-from-accounts-list page-token-from-page-details)]
(if (nil? page-token)
(runtime/log-strings "Could not find page access token for" id ". Token from the configuration will be used instead.")
(runtime/log-strings "Using page access token to retrieve data for" id))
(cond
(some? page-token)
(runtime/log-strings "Using page access token to retrieve data for" id)
(and (nil? accounts) (nil? page-token-from-page-details))
(runtime/log-error (str "Page token failed for " id ": both /me/accounts and page details API failed. "
"The user token will be used but may lack permissions for insights queries."))
:else
(runtime/log-strings "Could not find page access token for" id ". Token from the configuration will be used instead."))
page-token))

(defn choose-token [id user-token version]
Expand Down
Loading