fix: add user_segment_key to insights PK candidates (SUPPORT-15309)#126
Closed
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Closed
fix: add user_segment_key to insights PK candidates (SUPPORT-15309)#126devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Conversation
Co-Authored-By: olena.marchuk@keboola.com <olena.marchuk@keboola.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: olena.marchuk@keboola.com <olena.marchuk@keboola.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
user_segment_keyto theTABLES-SPECIFIC-PK-MAPfor the "insights" table. This is a Facebook Ads breakdown dimension for Advantage+ Shopping Campaigns (ASC) that segments by user type (new vs existing). Without it in the PK candidates, rows that differ only byuser_segment_keyare deduplicated incorrectly, dropping data.The column is only included in the actual PK when present in the output table (
get-primary-keyfilters viatable-has-column?), so existing configs without this breakdown are unaffected.Addresses SUPPORT-15309.
Updates since last revision
Added
keboola.ex-facebook-ads-v2to the CI workflow (push.yml):buildjob so branch tags are available for testing on the v2 componentaction-set-tag-developer-portalstep in thedeployjob for semantic tag releasesPreviously the CI only pushed to
keboola.ex-facebook,keboola.ex-facebook-ads, andkeboola.ex-instagram— thekeboola.ex-facebook-ads-v2component (which is the one customers actually use) was missing.Review & Testing Checklist for Human
user_segment_keyis the exact column name returned by the Facebook Ads API when using this breakdown (per Meta docs it should be, but confirm against live data)keboola.ex-facebook-ads-v2) using tag1770929310-SUPPORT-15309-add-user-segment-key-pk— confirm output table now includesuser_segment_keyin the PK and rows are no longer droppeduser_segment_keybreakdown produces identical output/PK as beforekeboola+facebook_extractor_github_actions) has proper permissions forkeboola.ex-facebook-ads-v2in the Developer Portal (the branch build succeeded, but verify deploy-timeset-tagwill also work on a semantic release)Notes
Release Notes
Justification, description
Added
user_segment_key(Advantage+ Shopping Campaign user segment breakdown) to the primary key candidates for insights tables, fixing incorrect row deduplication when this breakdown is used. Also addedkeboola.ex-facebook-ads-v2to CI build/deploy targets.Plans for Customer Communication
N/A
Impact Analysis
Low risk. Only affects configs that use the
user_segment_keybreakdown — those will now correctly include it in the PK. All other configs are unaffected. The CI change adds a new push target without modifying existing ones.Deployment Plan
N/A
Rollback Plan
N/A
Post-Release Support Plan
N/A