Merge pull request #2539 from keboola/mvasko/PSGO-198-push-validation-warnings

fix(push): downgrade JSON schema validation errors to warnings

Author: Matovidlo

pkg/lib/operation/project/sync/pull/operation.go

@@ -143,7 +143,7 @@ func Run(ctx context.Context, projectState *project.State, o Options, d dependen
 		logger.Warn(ctx, "")
 		logger.Warn(ctx, `The project has been pulled, but it is not in a valid state.`)
 		logger.Warn(ctx, `Please correct the problems listed above.`)
-		logger.Warn(ctx, `Push operation is only possible when project is valid.`)
+		logger.Warn(ctx, `Push will proceed with warnings for configs already accepted by the server.`)
 	}
 
 	// Log untracked paths

pkg/lib/operation/project/sync/push/operation.go

@@ -12,6 +12,7 @@ import (
 	"github.com/keboola/keboola-as-code/internal/pkg/project"
 	"github.com/keboola/keboola-as-code/internal/pkg/project/ignore"
 	"github.com/keboola/keboola-as-code/internal/pkg/telemetry"
+	"github.com/keboola/keboola-as-code/internal/pkg/utils/errors"
 	"github.com/keboola/keboola-as-code/pkg/lib/operation/project/local/encrypt"
 	"github.com/keboola/keboola-as-code/pkg/lib/operation/project/local/validate"
 	createDiff "github.com/keboola/keboola-as-code/pkg/lib/operation/project/sync/diff/create"
@@ -60,7 +61,10 @@ func Run(ctx context.Context, projectState *project.State, o Options, d dependen
 			ValidateJSONSchema: true,
 		}
 		if err := validate.Run(ctx, projectState, validateOptions, d); err != nil {
-			return err
+			logger.Warn(ctx, errors.Format(errors.PrefixError(err, "warning"), errors.FormatAsSentences()))
+			logger.Warn(ctx, "")
+			logger.Warn(ctx, "Validation warnings found, proceeding with push.")
+			logger.Warn(ctx, "The configs already exist on the server; the server is the source of truth.")
 		}
 	}
 

test/cli/pull/invalid-remote-state/expected-stderr

@@ -5,4 +5,4 @@ Warning:
 
 The project has been pulled, but it is not in a valid state.
 Please correct the problems listed above.
-Push operation is only possible when project is valid.
+Push will proceed with warnings for configs already accepted by the server.