fix: setLocaleFromURL (case-insensitive and handling fallback locales) 🌋#733
Open
darcywong00 wants to merge 1 commit into
Open
fix: setLocaleFromURL (case-insensitive and handling fallback locales) 🌋#733darcywong00 wants to merge 1 commit into
darcywong00 wants to merge 1 commit into
Conversation
* make regex case-insensitive * assign fallback locale
User Test ResultsTest specification and instructions User tests are not required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while integrating Keyman for Android which reports Spanish locale as
es-ESHad to make the following changes to setLocaleFromURL():
This way, the following link shows in Spanish (which uses es.php files)
http://keyman.com.localhost/es-ES/keyboards/?embed=android&embed_version=19.0
invalid locale like
http://keyman.com.localhost/rv-tS/keyboards/?embed=android&embed_version=19.0
appears in English
Test-bot: skip