Skip to content

chore: deprecate loading prop in EditBase and clarify usage #11249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Will-thom wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −4
Open

chore: deprecate loading prop in EditBase and clarify usage #11249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/ra-core/src/controller/create/CreateBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,10 @@ export interface CreateBaseProps<
children?: ReactNode;
render?: (props: CreateControllerResult<RecordType>) => ReactNode;
authLoading?: ReactNode;
/**
* @deprecated use authLoading instead
*/

/**
* @deprecated use the `saving` boolean returned by useCreateController instead.
* For authentication-related loading states, use `authLoading`.
*/
loading?: ReactNode;
}
7 changes: 6 additions & 1 deletion packages/ra-core/src/controller/edit/EditBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@ export interface EditBaseProps<
ErrorType = Error,
> extends EditControllerProps<RecordType, ErrorType> {
authLoading?: ReactNode;
loading?: ReactNode;

/**
* @deprecated use the `saving` boolean returned by useEditController instead.
* For authentication-related loading states, use `authLoading`.
*/
loading?: ReactNode;
offline?: ReactNode;
error?: ReactNode;
children?: ReactNode;
Expand Down