Skip to content

MAINT unify how default adversarial and scorer targets are set in scenarios#1695

Open
behnam-o wants to merge 12 commits intomicrosoft:mainfrom
behnam-o:scenario-targets
Open

MAINT unify how default adversarial and scorer targets are set in scenarios#1695
behnam-o wants to merge 12 commits intomicrosoft:mainfrom
behnam-o:scenario-targets

Conversation

@behnam-o
Copy link
Copy Markdown
Contributor

@behnam-o behnam-o commented May 6, 2026

Changes:

1- Use a common logic for resolving default adversarial and scorer targets in scenarios
2- Have a fallback mechanism that uses the target identified by OPENAI_CHAT_*** env variables. This allows someone to only define 1 endpoint and get a runnable scenario

@behnam-o behnam-o changed the title MAINT simplify how default scenario adversarial and scorer targets resolve MAINT simplify how default adversarial and scorer targets are set in scenarios May 6, 2026
Comment thread pyrit/scenario/core/scenario_target_defaults.py
Comment thread pyrit/scenario/core/scenario_target_defaults.py
Comment thread pyrit/scenario/core/scenario.py Outdated
Comment thread pyrit/scenario/core/scenario.py Outdated
Comment thread .env_example
@behnam-o behnam-o marked this pull request as ready for review May 7, 2026 19:57
@behnam-o behnam-o changed the title MAINT simplify how default adversarial and scorer targets are set in scenarios MAINT unify how default adversarial and scorer targets are set in scenarios May 7, 2026
Copy link
Copy Markdown
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@behnam-o behnam-o added this pull request to the merge queue May 7, 2026
@behnam-o behnam-o removed this pull request from the merge queue due to a manual request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants