Skip to content

Logs info/default log messages to eclipse logs only if tracing is #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raghucssit wants to merge 2 commits into
base: main
Choose a base branch
from
+33 −0
Open

Logs info/default log messages to eclipse logs only if tracing is #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9330bd2
Logs info/default log messages to eclipse logs only if tracing is
raghucssit Apr 27, 2026
7ebd6eb
Merge branch 'main' into filter_info_logs_trace
jdneo Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions ...opilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,16 @@
import org.eclipse.core.resources.IFile;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.jobs.Job;
import org.eclipse.e4.core.contexts.EclipseContextFactory;
import org.eclipse.e4.core.services.events.IEventBroker;
import org.eclipse.lsp4e.LanguageClientImpl;
import org.eclipse.lsp4j.ConfigurationItem;
import org.eclipse.lsp4j.ConfigurationParams;
import org.eclipse.lsp4j.MessageParams;
import org.eclipse.lsp4j.MessageType;
import org.eclipse.lsp4j.ProgressParams;
import org.eclipse.lsp4j.ShowDocumentParams;
import org.eclipse.lsp4j.ShowDocumentResult;
Expand Down Expand Up @@ -382,4 +385,34 @@ protected IStatus run(IProgressMonitor monitor) {
return super.showDocument(params);
}
}

@Override
public void logMessage(MessageParams message) {
if (message == null) {
return;
}

MessageType type = message.getType();
if (type == null) {
return;
}

switch (type) {
case Error:
case Warning:
super.logMessage(message);
break;
case Info:
case Log:
default:
if (isLsp4eLogTraceEnabled()) {
super.logMessage(message);
}
Comment on lines +406 to +410
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New behavior filters out Info/Log messages unless the LSP4E trace debug option is enabled. Since this is behaviorally significant and CopilotLanguageClient already has unit tests, please add/extend tests to verify Error/Warning are always delegated to super.logMessage(...), and Info/Log are only delegated when tracing is enabled.

Copilot generated this review using guidance from repository custom instructions.
break;
}
}

private boolean isLsp4eLogTraceEnabled() {
return Platform.getDebugBoolean("org.eclipse.lsp4e/trace");
}
}
Loading