feat: add tests for NES annotation type mapping and update plugin.xml for foreign text marker#29
Merged
feat: add tests for NES annotation type mapping and update plugin.xml for foreign text marker#29
Conversation
… for foreign text marker
There was a problem hiding this comment.
Pull request overview
Fixes the annotation-type mapping that caused Copilot’s Next Edit Suggestions (NES) delete annotation presentation (boxed red border) to be applied to unrelated third-party text markers (e.g., SonarQube), and adds regression tests to prevent reintroducing the generic marker mapping.
Changes:
- Remove
markerType="org.eclipse.core.resources.textmarker"from NES annotation type declarations to avoid mapping arbitrary text markers to Copilot NES annotations. - Add a UI test marker type (subtype of
textmarker) and JUnit tests asserting NES annotations don’t map to root text markers / foreign text markers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/plugin.xml | Removes root textmarker mapping for NES change/delete annotation types to prevent cross-plugin annotation conflicts. |
| com.microsoft.copilot.eclipse.ui.test/plugin.xml | Adds a “foreign” text marker type (subtype of textmarker) used to simulate third-party markers in tests. |
| com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/nes/NesAnnotationTypeMappingTest.java | Adds regression tests verifying foreign markers don’t resolve to NES annotations and NES types don’t map to root textmarker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #23