fix: update various components and add spec modules#36191
Merged
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
tudorpopams
approved these changes
May 12, 2026
marchbox
approved these changes
May 12, 2026
cddddda to
d92ff4c
Compare
d92ff4c to
c374e9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
<fluent-dialog>and<fluent-drawer>components managed ARIA attributes (aria-modal,role,aria-describedby,aria-labelledby,aria-label) imperatively viaupdateDialogAttributes()and aMutationObserver, outside of FAST's reactive binding system.<fluent-compound-button>template was missingclickandkeypressevent handler bindings that were present in the base<fluent-button>template.<fluent-rating-display>test had a Chromium-specific branch for gradient CSS assertions that fails on newer versions of Playwright.<fluent-compound-button><fluent-dialog-body><fluent-drawer-body><fluent-menu-button><fluent-menu-item>New Behavior
<fluent-dialog>and<fluent-drawer>ARIA attributes are now managed declaratively through@volatilegetters bound directly in the template, replacing the imperativeupdateDialogAttributes()/MutationObserverpattern.<fluent-compound-button>template now includesclickandkeypresshandler bindings matching the base<fluent-button>template.<fluent-rating-display>test no longer branches onbrowserNamefor gradient assertions.<fluent-compound-button><fluent-dialog-body><fluent-drawer-body><fluent-menu-button><fluent-menu-item>