Skip to content

fix: update various components and add spec modules#36191

Merged
radium-v merged 13 commits into
microsoft:masterfrom
radium-v:wc-add-more-tests
May 12, 2026
Merged

fix: update various components and add spec modules#36191
radium-v merged 13 commits into
microsoft:masterfrom
radium-v:wc-add-more-tests

Conversation

@radium-v
Copy link
Copy Markdown
Contributor

Previous Behavior

  • <fluent-dialog> and <fluent-drawer> components managed ARIA attributes (aria-modal, role, aria-describedby, aria-labelledby, aria-label) imperatively via updateDialogAttributes() and a MutationObserver, outside of FAST's reactive binding system.
  • The <fluent-compound-button> template was missing click and keypress event handler bindings that were present in the base <fluent-button> template.
  • The <fluent-rating-display> test had a Chromium-specific branch for gradient CSS assertions that fails on newer versions of Playwright.
  • No tests existed for:
    • <fluent-compound-button>
    • <fluent-dialog-body>
    • <fluent-drawer-body>
    • <fluent-menu-button>
    • <fluent-menu-item>

New Behavior

  • Playwright has been updated to version 1.56.1
  • <fluent-dialog> and <fluent-drawer> ARIA attributes are now managed declaratively through @volatile getters bound directly in the template, replacing the imperative updateDialogAttributes() / MutationObserver pattern.
  • The <fluent-compound-button> template now includes click and keypress handler bindings matching the base <fluent-button> template.
  • The <fluent-rating-display> test no longer branches on browserName for gradient assertions.
  • New Playwright spec files added for:
    • <fluent-compound-button>
    • <fluent-dialog-body>
    • <fluent-drawer-body>
    • <fluent-menu-button>
    • <fluent-menu-item>

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

📊 Bundle size report

✅ No changes found

@github-actions
Copy link
Copy Markdown

Pull request demo site: URL

@radium-v radium-v self-assigned this May 12, 2026
@radium-v radium-v force-pushed the wc-add-more-tests branch from cddddda to d92ff4c Compare May 12, 2026 18:28
@radium-v radium-v force-pushed the wc-add-more-tests branch from d92ff4c to c374e9a Compare May 12, 2026 18:29
@radium-v radium-v merged commit 28238eb into microsoft:master May 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants