sketch: refactor lowlevel server to handler pattern#1968
Closed
maxisbey wants to merge 17 commits into
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces decorator-based handler registration with
RequestHandler/NotificationHandlerclasses.Changes
request_handler.pyandnotification_handler.pywith typed overloaded constructorstype(req)→req.method(string-based dispatch)dict[type, Callable]→dict[str, RequestHandler]/dict[str, NotificationHandler]handlerslist +add_handler()methodRequestContextbuilt and passed directly to handlers;request_ctxcontextvar removed_make_error_result,_get_cached_tool_definition,new_server.pysketchKnown breakages
MCPServer._setup_handlers()— calls removed decorator methodsExperimentalHandlers— writes to handler dicts with type keys