Add failing spec for sorted block with missing sorted property#13
Open
Stuk wants to merge 2 commits intomontagejs:masterfrom
Open
Add failing spec for sorted block with missing sorted property#13Stuk wants to merge 2 commits intomontagejs:masterfrom
Stuk wants to merge 2 commits intomontagejs:masterfrom
Conversation
Contributor
Author
|
Added another failing spec :( |
Member
|
Joy. Nothing can be simple :P |
Member
|
I’m now convinced that this should be solved by omitting values from the output if the relation produces null. This probably involves tracking whether each value is currently included in the output. SortedArray in Collections should be modified to complain loudly if someone adds an incomparable value, as SortedSet already does. |
Contributor
Author
I'm not sure what you mean by this. Would it mean that line 43 of the diff would read expect(object.sorted.length).toEqual(0);but the remainder of that test would remain the same? |
Member
|
@Stuk Yes, I believe that might work. |
Contributor
Contributor
|
montagejs/collections#171 landed in collections master need release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of items in the array increase(!) when the property that is sorted on does not exist in the objects, and is then added.