Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR automates certificate renewal by consolidating multiple renewal scripts into a single script and ensuring certificates are renewed when necessary. The key changes include:
- Adding SCRIPT_DIR initialization in utils.sh for easier path management.
- Replacing multiple individual renewal script calls with a unified cert-renew.sh in master.sh and cron-master.sh.
- Introducing a new cert-renew.sh that checks for certificate renewal needs and applies a force flag as needed.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/utils.sh | Added SCRIPT_DIR initialization and adjusted renewal check logic. |
| scripts/master.sh | Replaced individual certificate renewal calls with a unified script invocation. |
| scripts/cron-master.sh | Updated to remove git lock file, pull latest changes, and run the unified renewal script. |
| scripts/cert-renew.sh | New script that centralizes certificate renewal and container restart logic. |
| scripts/cert-check.py | New script that validates certificate expiry dates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@a-thieme @tianyuan129