Skip to content

crypto: reject invalid raw key imports#63134

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:raw-format-fixes
Open

crypto: reject invalid raw key imports#63134
panva wants to merge 1 commit intonodejs:mainfrom
panva:raw-format-fixes

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented May 5, 2026

Fixes a couple edge cases related to raw key formats in node:crypto.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. labels May 5, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 67.69231% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (18f938d) to head (03c121c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_keys.cc 60.37% 2 Missing and 19 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63134   +/-   ##
=======================================
  Coverage   89.67%   89.68%           
=======================================
  Files         712      712           
  Lines      221251   221305   +54     
  Branches    42393    42417   +24     
=======================================
+ Hits       198413   198481   +68     
+ Misses      14681    14627   -54     
- Partials     8157     8197   +40     
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 97.05% <100.00%> (+0.01%) ⬆️
lib/internal/crypto/ml_kem.js 94.66% <100.00%> (ø)
src/crypto/crypto_pqc.cc 85.85% <100.00%> (+3.06%) ⬆️
src/crypto/crypto_keys.cc 71.59% <60.37%> (-1.25%) ⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 5, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants