Skip to content

test_runner: fix diagnostics channel context tracking#63283

Open
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-diagnostic-channel
Open

test_runner: fix diagnostics channel context tracking#63283
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-diagnostic-channel

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented May 13, 2026

No description provided.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 13, 2026
Comment thread test/parallel/test-runner-diagnostics-channel.js Outdated
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
@MoLow MoLow force-pushed the fix-test-runner-diagnostic-channel branch from 192072e to fa0a640 Compare May 13, 2026 11:05
@MoLow MoLow requested a review from atlowChemi May 13, 2026 11:05
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (131fd84) to head (fa0a640).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/test.js 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63283      +/-   ##
==========================================
- Coverage   91.94%   90.06%   -1.89%     
==========================================
  Files         362      714     +352     
  Lines      155999   225251   +69252     
  Branches    24057    42583   +18526     
==========================================
+ Hits       143429   202864   +59435     
- Misses      12295    14171    +1876     
- Partials      275     8216    +7941     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.00% <95.00%> (+0.06%) ⬆️

... and 477 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants