Streamline local Ollama embeddings#2012
Streamline local Ollama embeddings#2012fuller-stack-dev wants to merge 2 commits intoopenclaw:mainfrom
Conversation
|
@fuller-stack-dev is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: needs maintainer review before merge. Summary Reproducibility: not applicable. this is a feature PR, not a bug report. Source inspection confirms current main lacks the requested Ollama provider/setup/docs and PR head adds targeted tests for the new behavior. Next step before merge Security Review detailsBest possible solution: Land the PR after maintainer acceptance of the local Ollama default and normal CI, keeping provider selection centralized in the embedding helper with docs and seed behavior aligned. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature PR, not a bug report. Source inspection confirms current main lacks the requested Ollama provider/setup/docs and PR head adds targeted tests for the new behavior. Is this the best way to solve the issue? Yes, pending product acceptance: centralizing provider selection in convex/lib/embeddings.ts and passing generated vectors through seed actions is the narrow maintainable path. I did not find a safer implementation direction from this review. Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 395862fadf63. |
|
Addressed the review feedback by adding the required New commit: caec0a9 ( Verified: bun run format:check -- CHANGELOG.md |
caec0a9 to
2da46c2
Compare
|
Updated the changelog entry to match the existing attribution style: (#2012) (thanks @fuller-stack-dev)Amended commit: 2da46c2 ( Verified: bun run format:check -- CHANGELOG.md |
Summary
OPENAI_API_KEYis absentbun run setup:local-embeddingsto pull/configure the default local embedding modelTests
bunx vitest run convex/lib/embeddings.test.tsbunx tsc --noEmitbun run lintbun run testnode scripts/setup-local-embeddings.mjs --helpbun run format:check -- convex/lib/embeddings.ts convex/lib/embeddings.test.ts convex/devSeed.ts convex/devSeedExtra.ts convex/lib/skillPublish.ts convex/lib/soulPublish.ts scripts/setup-local-embeddings.mjs package.json README.md CONTRIBUTING.md docs/README.md docs/quickstart.md docs/troubleshooting.md docs/local-embeddings.mdNote: full
bun run format:checkwas also attempted locally, but failed only on pre-existing unstaged.agents/...worktree files that are not included in this PR.