Drop 4.15.63 tombstoned release from candidate channels#9286
Drop 4.15.63 tombstoned release from candidate channels#9286germanparente wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: germanparente The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@wking I know this is not urgent but don't hesitate to approve this as possible |
| - 4.15.60 | ||
| - 4.15.61 | ||
| - 4.15.62 | ||
| - 4.15.63 |
There was a problem hiding this comment.
We can tombstone releases, but we don't drop them from channels. Dropping would make it harder for folks on that release in that channel to update out to a fixed release.
There was a problem hiding this comment.
hi @wking
Does the same also apply to channels/candidate-4.16.yaml ?
i.e. do not remove the row from channels/candidate-4.16.yaml also?
Thanks
|
Thanks @wking I have updated the PR to tombstone 4.15.63. so, the traces of 4.15.63 are still in 4.15 / 4.16 channels. |
|
/test e2e |
|
@wking |
| - 4.19.29 | ||
| - 4.21.12 | ||
| - 4.16.60 | ||
| - 4.15.63 |
There was a problem hiding this comment.
You're still dropping this entry. Doesn't really matter, because it's currently only an internal channel. But all you should be doing when tombstoning is adding the tombstones entry up around line 115.
There was a problem hiding this comment.
Thanks @wking I will fix this asap.
I know that candidate channel is not really very importante since it's not even supported. Thanks for reminding me of that.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@germanparente: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.