Skip to content

Drop 4.15.63 tombstoned release from candidate channels#9286

Open
germanparente wants to merge 6 commits into
openshift:masterfrom
germanparente:4.15.63tombstone
Open

Drop 4.15.63 tombstoned release from candidate channels#9286
germanparente wants to merge 6 commits into
openshift:masterfrom
germanparente:4.15.63tombstone

Conversation

@germanparente
Copy link
Copy Markdown

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f1aa1934-185b-4734-b7a3-e38006cd1b18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from DavidHurta and wking April 29, 2026 08:03
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente
Once this PR has been reviewed and has the lgtm label, please assign dustman9000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@germanparente
Copy link
Copy Markdown
Author

@wking I know this is not urgent but don't hesitate to approve this as possible

- 4.15.60
- 4.15.61
- 4.15.62
- 4.15.63
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can tombstone releases, but we don't drop them from channels. Dropping would make it harder for folks on that release in that channel to update out to a fixed release.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @wking
Does the same also apply to channels/candidate-4.16.yaml ?
i.e. do not remove the row from channels/candidate-4.16.yaml also?
Thanks

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, applies to all channels

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2026
@germanparente
Copy link
Copy Markdown
Author

Thanks @wking I have updated the PR to tombstone 4.15.63.

so, the traces of 4.15.63 are still in 4.15 / 4.16 channels.

@germanparente
Copy link
Copy Markdown
Author

/test e2e

@rhdmalone
Copy link
Copy Markdown

@wking
if possible, could you approve this PR as it tidies up tombstoning of 4.15.63 from last week please ?
Thanks very much

- 4.19.29
- 4.21.12
- 4.16.60
- 4.15.63
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're still dropping this entry. Doesn't really matter, because it's currently only an internal channel. But all you should be doing when tombstoning is adding the tombstones entry up around line 115.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wking I will fix this asap.
I know that candidate channel is not really very importante since it's not even supported. Thanks for reminding me of that.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@germanparente: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-release aa6403e link true /test validate-release
ci/prow/e2e-latest-cincinnati aa6403e link false /test e2e-latest-cincinnati
ci/prow/e2e aa6403e link true /test e2e
ci/prow/images aa6403e link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants