Skip to content

[release-4.21] OCPBUGS-84655: fix openshift/network/third-party suite selecting zero tests#31091

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-31084-to-release-4.21
May 8, 2026
Merged

[release-4.21] OCPBUGS-84655: fix openshift/network/third-party suite selecting zero tests#31091
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-31084-to-release-4.21

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #31084

/assign petr-muller

… tests

The openshift/network/third-party suite CEL qualifier used
name.contains("[Suite:k8s]") to identify upstream Kubernetes tests, but
no tests carry that tag after the OTE migration. Replace with
source == "openshift:payload:hyperkube" which is the correct way to
identify upstream k8s tests in the extension framework.

Add a semantic test that verifies the qualifier actually matches expected
test specs, preventing future regressions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a3b8fc4f-3122-47ed-9118-aad7d3c244d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from p0lyn0mial and sjenning April 29, 2026 01:28
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-84257 has been cloned as Jira Issue OCPBUGS-84655. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-84655: fix openshift/network/third-party suite selecting zero tests

Details

In response to this:

This is an automated cherry-pick of #31084

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.21] OCPBUGS-84257: fix openshift/network/third-party suite selecting zero tests [release-4.21] OCPBUGS-84655: fix openshift/network/third-party suite selecting zero tests Apr 29, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84655, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-84257 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-84257 to target a version in 4.22.0, but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #31084

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@petr-muller
Copy link
Copy Markdown
Member

/uncc @p0lyn0mial @sjenning

@petr-muller
Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@petr-muller: This pull request references Jira Issue OCPBUGS-84655, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@petr-muller
Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@petr-muller: This pull request references Jira Issue OCPBUGS-84655, which is invalid:

  • expected Jira Issue OCPBUGS-84655 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@petr-muller
Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@petr-muller: This pull request references Jira Issue OCPBUGS-84655, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-84654 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-84654 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@petr-muller
Copy link
Copy Markdown
Member

Running against a cluster bot cluster obtained with launch 4.21,openshift/origin#31091 aws:

Dry run works:

$ set TESTS_IMAGE (oc adm release info --image-for=tests "$(oc get clusterversion version -o jsonpath='{.status.desired.image}')")
$ podman run --network=host -v "$PWD":/data:z --rm -it $TESTS_IMAGE sh -c 'KUBECONFIG=/data/cluster-bot-2026-05-07-190426.kubeconfig /usr/bin/openshift-tests run openshift/network/third-party --dry-run'
I0507 23:11:56.461744       1 factory.go:195] Registered Plugin "containerd"
  I0507 23:11:56.474340       1 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US
  I0507 23:11:56.697920       1 binary.go:77] Found 8527 test specs
  I0507 23:11:56.700311       1 binary.go:94] 1077 test specs remain, after filtering out k8s
openshift-tests v4.1.0-10590-ge043810
INFO[0000] Using target cluster release image            release_image="registry.build10.ci.openshift.org/ci-ln-yp2bh42/release@sha256:ae2b786dd3d1f05f23006732411a98348ca31ab27cdb33e5eb40bdc88d3257f5"
...
INFO[0150] Listed 1 tests in 20.734588ms                 binary=cluster-kube-apiserver-operator-tests-ext
INFO[0150] Listed 1 tests in 9.695792ms                  binary=cluster-config-operator-tests-ext
INFO[0150] Listed 0 tests in 8.608721ms                  binary=cluster-kube-scheduler-operator-tests-ext
INFO[0150] Listed 0 tests in 7.470248ms                  binary=cluster-kube-storage-version-migrator-operator-tests-ext
INFO[0150] Listed 118 tests in 52.870516ms               binary=olmv0-tests-ext
INFO[0150] Listed 22 tests in 68.064126ms                binary=machine-config-tests-ext
INFO[0150] Listed 86 tests in 49.031026ms                binary=olmv1-tests-ext
INFO[0150] Listed 0 tests in 262.052178ms                binary=machine-api-tests-ext
INFO[0150] Listed 1056 tests in 385.036863ms             binary=openshift-tests
INFO[0150] Listed 6968 tests in 472.785495ms             binary=k8s-tests-ext
INFO[0150] Discovered 8284 total tests
INFO[0150] Generated skips for cluster state             skips="[[Skipped:skeleton] [Feature:Networking-IPv4] [Feature:Networking-IPv6] [Feature:IPv6DualStack [Feature:SCTPConnectivity] [Requires:HypervisorSSHConfig]]"
INFO[0150] Applying filter: suite-qualifiers             before=8284 component=test-filter filter=suite-qualifiers
INFO[0151] Filter suite-qualifiers completed - removed 8183 tests  after=101 before=8284 component=test-filter filter=suite-qualifiers removed=8183
INFO[0151] Applying filter: kube-rebase-tests            before=101 component=test-filter filter=kube-rebase-tests
INFO[0151] Filter kube-rebase-tests completed - removed 0 tests  after=101 before=101 component=test-filter filter=kube-rebase-tests removed=0
INFO[0151] Applying filter: disabled-tests               before=101 component=test-filter filter=disabled-tests
INFO[0151] Filter disabled-tests completed - removed 0 tests  after=101 before=101 component=test-filter filter=disabled-tests removed=0
INFO[0151] Applying filter: cluster-state                before=101 component=test-filter filter=cluster-state
INFO[0151] Filter cluster-state completed - removed 26 tests  after=75 before=101 component=test-filter filter=cluster-state removed=26
INFO[0151] Filter chain completed with 75 tests          component=test-filter final_count=75
"[sig-network] DNS should provide /etc/hosts entries for the cluster [Conformance]"
"[sig-network] DNS should provide DNS for ExternalName services [Conformance]"
"[sig-network] DNS should provide DNS for pods for Hostname [Conformance]"
...

Without --dry-run, the tests executed as normal.

/verified by @petr-muller
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 7, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@petr-muller: This PR has been marked as verified by @petr-muller.

Details

In response to this:

Running against a cluster bot cluster obtained with launch 4.21,openshift/origin#31091 aws:

Dry run works:

$ set TESTS_IMAGE (oc adm release info --image-for=tests "$(oc get clusterversion version -o jsonpath='{.status.desired.image}')")
$ podman run --network=host -v "$PWD":/data:z --rm -it $TESTS_IMAGE sh -c 'KUBECONFIG=/data/cluster-bot-2026-05-07-190426.kubeconfig /usr/bin/openshift-tests run openshift/network/third-party --dry-run'
I0507 23:11:56.461744       1 factory.go:195] Registered Plugin "containerd"
 I0507 23:11:56.474340       1 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US
 I0507 23:11:56.697920       1 binary.go:77] Found 8527 test specs
 I0507 23:11:56.700311       1 binary.go:94] 1077 test specs remain, after filtering out k8s
openshift-tests v4.1.0-10590-ge043810
INFO[0000] Using target cluster release image            release_image="registry.build10.ci.openshift.org/ci-ln-yp2bh42/release@sha256:ae2b786dd3d1f05f23006732411a98348ca31ab27cdb33e5eb40bdc88d3257f5"
...
INFO[0150] Listed 1 tests in 20.734588ms                 binary=cluster-kube-apiserver-operator-tests-ext
INFO[0150] Listed 1 tests in 9.695792ms                  binary=cluster-config-operator-tests-ext
INFO[0150] Listed 0 tests in 8.608721ms                  binary=cluster-kube-scheduler-operator-tests-ext
INFO[0150] Listed 0 tests in 7.470248ms                  binary=cluster-kube-storage-version-migrator-operator-tests-ext
INFO[0150] Listed 118 tests in 52.870516ms               binary=olmv0-tests-ext
INFO[0150] Listed 22 tests in 68.064126ms                binary=machine-config-tests-ext
INFO[0150] Listed 86 tests in 49.031026ms                binary=olmv1-tests-ext
INFO[0150] Listed 0 tests in 262.052178ms                binary=machine-api-tests-ext
INFO[0150] Listed 1056 tests in 385.036863ms             binary=openshift-tests
INFO[0150] Listed 6968 tests in 472.785495ms             binary=k8s-tests-ext
INFO[0150] Discovered 8284 total tests
INFO[0150] Generated skips for cluster state             skips="[[Skipped:skeleton] [Feature:Networking-IPv4] [Feature:Networking-IPv6] [Feature:IPv6DualStack [Feature:SCTPConnectivity] [Requires:HypervisorSSHConfig]]"
INFO[0150] Applying filter: suite-qualifiers             before=8284 component=test-filter filter=suite-qualifiers
INFO[0151] Filter suite-qualifiers completed - removed 8183 tests  after=101 before=8284 component=test-filter filter=suite-qualifiers removed=8183
INFO[0151] Applying filter: kube-rebase-tests            before=101 component=test-filter filter=kube-rebase-tests
INFO[0151] Filter kube-rebase-tests completed - removed 0 tests  after=101 before=101 component=test-filter filter=kube-rebase-tests removed=0
INFO[0151] Applying filter: disabled-tests               before=101 component=test-filter filter=disabled-tests
INFO[0151] Filter disabled-tests completed - removed 0 tests  after=101 before=101 component=test-filter filter=disabled-tests removed=0
INFO[0151] Applying filter: cluster-state                before=101 component=test-filter filter=cluster-state
INFO[0151] Filter cluster-state completed - removed 26 tests  after=75 before=101 component=test-filter filter=cluster-state removed=26
INFO[0151] Filter chain completed with 75 tests          component=test-filter final_count=75
"[sig-network] DNS should provide /etc/hosts entries for the cluster [Conformance]"
"[sig-network] DNS should provide DNS for ExternalName services [Conformance]"
"[sig-network] DNS should provide DNS for pods for Hostname [Conformance]"
...

Without --dry-run, the tests executed as normal.

/verified by @petr-muller
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 61dad4d into openshift:release-4.21 May 8, 2026
9 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-84655
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84655 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #31084

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants