Skip to content

Added Schema check in Announcements plugin. #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drkthunder02 wants to merge 1 commit into from
+12 −10
Closed

Added Schema check in Announcements plugin. #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions announcements/database/migrations/001_create_announcements_table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,18 @@
{
public function up(): void
{
Schema::create('announcements', function (Blueprint $table) {
$table->increments('id');
$table->string('title');
$table->string('body')->nullable();
$table->string('type')->default('info');
$table->json('panels')->nullable();
$table->timestamp('valid_from')->nullable();
$table->timestamp('valid_to')->nullable();
$table->timestamps();
});
if(!Schema::hasTable('announcements')) {
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix Pint style violation on the conditional (currently blocking CI).

Line 11 should follow Laravel/Pint spacing conventions; this is likely the single lint failure in the pipeline.

Suggested fix 
-        if(!Schema::hasTable('announcements')) {
+        if (! Schema::hasTable('announcements')) {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if(!Schema::hasTable('announcements')) {
if (! Schema::hasTable('announcements')) {
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@announcements/database/migrations/001_create_announcements_table.php` at line
11, The conditional spacing for the table-check is violating Pint rules; update
the if statement that calls Schema::hasTable('announcements') to follow
Laravel/Pint spacing (e.g. change "if(!Schema::hasTable('announcements')) {" to
"if (! Schema::hasTable('announcements')) {" or the project-preferred variant
"if (!Schema::hasTable('announcements')) {"), modifying the line that contains
Schema::hasTable('announcements') in the migration to match the linter's
expected spacing.

Schema::create('announcements', function (Blueprint $table) {
$table->increments('id');
$table->string('title');
$table->string('body')->nullable();
$table->string('type')->default('info');
$table->json('panels')->nullable();
$table->timestamp('valid_from')->nullable();
$table->timestamp('valid_to')->nullable();
$table->timestamps();
});
}
}

public function down(): void
Expand Down
Loading