Skip to content

Ignore zpp in gcovr #21623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iluuu1994 merged 1 commit into from
Apr 3, 2026
+12 −18
Merged

Ignore zpp in gcovr #21623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,15 @@ jobs:
with:
enableOpcache: true
jitType: tracing
- name: Generate coverage report
if: ${{ !cancelled() }}
run: make gcovr-xml
- uses: codecov/codecov-action@v5
if: ${{ !cancelled() }}
with:
disable_search: true
fail_ci_if_error: true
files: gcovr.xml
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
COMMUNITY:
Expand Down
10 changes: 7 additions & 3 deletions build/Makefile.gcov
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@ GCOVR_EXCLUDES = \
'ext/fileinfo/libmagic/.*' \
'ext/gd/libgd/.*' \
'ext/hash/sha3/.*' \
'ext/lexbor/lexbor/.*' \
'ext/mbstring/libmbfl/.*' \
'ext/pcre/pcre2lib/.*'
'ext/pcre/pcre2lib/.*' \
'ext/uri/uriparser/.*'
Copy link
Copy Markdown
Contributor

@mvorisek mvorisek Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the uriparser bundled lib be also excluded from LCOV?

Would you like to be this automatized, ie. exclude all bundled sources, by CI?

Copy link
Copy Markdown
Member Author

@iluuu1994 iluuu1994 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lcov is currently broken, and honestly I'm not sure it even makes sense to maintain two tools.


GCOVR_EXCLUDE_LINES_BY_PATTERN = '.*\b(ZEND_PARSE_PARAMETERS_(START|END|NONE)|Z_PARAM_).*'

lcov: lcov-html

Expand All @@ -49,14 +53,14 @@ gcovr-html:
@rm -rf gcovr_html/
@mkdir gcovr_html
gcovr -sr . -o gcovr_html/index.html --html --html-details \
--exclude-directories 'ext/date/lib$$' \
--exclude-lines-by-pattern $(GCOVR_EXCLUDE_LINES_BY_PATTERN) \
$(foreach lib, $(GCOVR_EXCLUDES), -e $(lib))

gcovr-xml:
@echo "Generating gcovr XML"
@rm -f gcovr.xml
gcovr -sr . -o gcovr.xml --xml \
--exclude-directories 'ext/date/lib$$' \
--exclude-lines-by-pattern $(GCOVR_EXCLUDE_LINES_BY_PATTERN) \
$(foreach lib, $(GCOVR_EXCLUDES), -e $(lib))

.PHONY: gcovr-html lcov-html php_lcov.info
15 changes: 0 additions & 15 deletions codecov.yml
View file
Open in desktop

This file was deleted.

Loading