Skip to content

Add collision-detector.json to export-ignore in .gitattributes#315

Merged
staabm merged 1 commit intophpstan:2.0.xfrom
sasezaki:patch-gitattributes
May 7, 2026
Merged

Add collision-detector.json to export-ignore in .gitattributes#315
staabm merged 1 commit intophpstan:2.0.xfrom
sasezaki:patch-gitattributes

Conversation

@sasezaki
Copy link
Copy Markdown
Contributor

@sasezaki sasezaki commented May 7, 2026

Current archive targets other than src/ will be as follows:

gh api repos/phpstan/phpstan-strict-rules/tarball/HEAD | tar -tzf - | cut -d/ -f2- | sed '/^$/d' | grep -vE '^src/' | sort
collision-detector.json
composer.json
LICENSE
README.md
rules.neon

With this PR, the archive targets other than src/ will be as follows:

gh api repos/sasezaki/phpstan-strict-rules/tarball/patch-gitattributes | tar -tzf - | cut -d/ -f2- | sed '/^$/d' | grep -vE '^src/' | sort
composer.json
LICENSE
README.md
rules.neon

Changes:

  • Added collision-detector.json export-ignore
    • collision-detector.json: Configuration for shipmonk/name-collision-detector (a dev tool); not needed by package consumers.

@VincentLanglet VincentLanglet requested a review from staabm May 7, 2026 17:10
@staabm staabm merged commit 470946d into phpstan:2.0.x May 7, 2026
44 checks passed
@staabm
Copy link
Copy Markdown
Contributor

staabm commented May 7, 2026

Thank you

@staabm
Copy link
Copy Markdown
Contributor

staabm commented May 7, 2026

Could you do the same thing for https://github.com/phpstan/phpstan-doctrine ?

@sasezaki
Copy link
Copy Markdown
Contributor Author

sasezaki commented May 7, 2026

@staabm

Could you do the same thing for https://github.com/phpstan/phpstan-doctrine ?

Done
phpstan/phpstan-doctrine#746

@sasezaki sasezaki deleted the patch-gitattributes branch May 7, 2026 22:26
@staabm
Copy link
Copy Markdown
Contributor

staabm commented May 8, 2026

@sasezaki thank you very much.

in case you are interessted you could send a new PR adding the collision detector to all other 1st party PHPStan repos, in which its missing atm.

effectively porting #315 into the other repos (including your .gitattributes change you did in this PR here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants