Replaces 'Your AUTH_ID' with process.env.authId and same for token#11
Open
Rafael Cosman (RafaelCosman) wants to merge 1 commit intoplivo:masterfrom
Open
Replaces 'Your AUTH_ID' with process.env.authId and same for token#11Rafael Cosman (RafaelCosman) wants to merge 1 commit intoplivo:masterfrom
Rafael Cosman (RafaelCosman) wants to merge 1 commit intoplivo:masterfrom
Conversation
Rafael Cosman (RafaelCosman)
added a commit
to RafaelCosman/plivo-node
that referenced
this pull request
Jan 28, 2016
I've also made this change in plivo/plivo-examples-node: See plivo/plivo-examples-node#11.
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This encourages developers to use environment variables as opposed to leaving their authId and authToken directly in the code. Using environment variables for data of this type is a standard best practice. Putting tokens in code can jeopardize the application's data and user's data.
I've also made this change in plivo/plivo-node's readme: see plivo/plivo-node#36.