Skip to content

Feat/collection list pagination#4110

Closed
VaibhavNarayann wants to merge 110 commits intoprocessing:developfrom
VaibhavNarayann:feat/collection-list-pagination
Closed

Feat/collection list pagination#4110
VaibhavNarayann wants to merge 110 commits intoprocessing:developfrom
VaibhavNarayann:feat/collection-list-pagination

Conversation

@VaibhavNarayann
Copy link
Copy Markdown

@VaibhavNarayann VaibhavNarayann commented May 7, 2026 •
edited
Loading

Related to #3880

Description

Added pagination to the Collection List page only.

Demo

image

Changes

  • Added Pagination component to CollectionList
  • Added collectionsListProjects reducer

Notes

  • This PR covers Collection List pagination only
  • Asset List pagination will be handled in a separate PR as requested in the issue

TODO

  • Unit tests for CollectionList pagination (will add based on maintainer feedback)

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch
  • is descriptively named and links to an issue number i.e Related to #3880
  • meets the standards outlined in the accessibility guidelines

khanniie and others added 30 commits January 24, 2025 00:15
@khanniie
Split off hinter functionality into a separate file
84b135b
@khanniie
update docstring in hinter
10da30e
@khanniie
move csslint to hint file
44e5cfc
@khanniie
fix bug where i forgot to pass in the cm instance to hide the hinter
850845a
@khanniie
Merge pull request processing#3327 from processing/connie-editor-conv…
4d9b05f 
…ersion-hint-file

Editor file splitting: create new hint file
@khanniie
Moves the tidier code and file mode out of editor file
0651ccf
@raclim
Merge pull request processing#3335 from processing/connie-editor-conv…
f7cbcab 
…ersion-utils-tidy

Moves the tidier code and file mode utils out of editor file
@khanniie
Merge branch 'develop' into connie-develop
dc1b51d
@khanniie
Merge branch 'develop' into connie-develop
249e728
@Vishawdeep-Singh @khanniie
fix Exiting Multi-Line Cursor Doesnt Return to the Original Cursor
fe0d19f
@raclim @khanniie
remove extra console log
ce37415
@khanniie
pull out codemirror test
c1102d9
@khanniie
Convert editor file to functional
2c917a2
@khanniie
change CM fifle to a useCodeMirror custom hook
55bb4a5
@khanniie
fix codemirror file debounce bug
7c822b1
@khanniie
fix codemirrorr bug with debouncer again
1e575f9
@khanniie
only useeffect on file id change
107e9bf
@khanniie
switches from using usePrevious to an existing hook
e45d265
@khanniie
moves document management to the cm file
0ac3234
@khanniie
fix test error
f3f7ab4
@khanniie
fix mobile bug
6d7ef6d
@khanniie
adds comments, removes a logic block that wasn't doing anything
ea815f7 
I'm fairly certain that we can remove ```
      if (!prevProps?.unsavedChanges) {
        setTimeout(() => setUnsavedChanges(false), 400);
      }
```

I looked at the git blame and it looks like the intention was to stop setting unsavedchanges to false when the files switched, but i think the solve that was implemented 9 years ago did something like "if c == false, c = false" and we should be able to safely remove it instead.

reference commit: processing@77e2f5b
@khanniie
add TODO
36c4129
@raclim
Merge pull request processing#3352 from processing/connie-editor-conv…
9fd608d 
…ersion-splitoff-codemirror

Convert Editor to functional, splits off CodeMirror code into its own file
@khanniie
merge develop into cm-develop
172d573
@khanniie
merge old develop branch into connie's cm develop branch
52a3b53
@khanniie
codemirror v5 -> v6
5d3d93d
@khanniie
Update codemirror.js
619f1c4
@khanniie
remove unused cm5 styles
2e85808
@khanniie
remove cm5 plugins
c12d18a
raclim and others added 23 commits March 22, 2026 23:04
@raclim
update func name, add ghost text util
e77e2a6
@raclim
add styling for hinter
5931f13
@raclim
Merge pull request processing#4006 from processing/cm6-color-picker-i…
0f8ac70 
…mport

[codemirror6] Fix color picker to work in Javascript
@raclim
tweak wording
d411d2d
@khanniie
Merge pull request processing#4043 from processing/autocomplete-hinte…
b5e6852 
…r-parity
@Geethegreat
merge upstream/develop-codemirror-v6 to resolve conflicts
bdff696
@khanniie
Merge pull request processing#3825 from Geethegreat/json-lint
0bfda9c
@khanniie
Merge branch 'develop' into develop-codemirror-v6
477aad6
@khanniie
Update package-lock.json
38773a6
@khanniie
Add back reference url for p5 v2 change
dd02f07
@khanniie
merge
2258399
@khanniie
merge??
0b40206
@Nishthajain7
Migrated to ESlint
957a9c6
@Nishthajain7
Resolved Merge Conflicts
bac3fbe
@khanniie
add reference url to useEffect and clean up comments
80b2e8e
@khanniie
Merge pull request processing#3836 from Nishthajain7/migarte-to-eslint
3d020a5 
Migrated from JSHint to ESLint
@khanniie
Merge branch 'develop-codemirror-v6' of https://github.com/processing…
67e6674 
…/p5.js-web-editor into develop-codemirror-v6
@khanniie
cleanup imports
b7a4de9
@khanniie
Revert "cleanup imports"
4cdace3 
This reverts commit b7a4de9.
@VaibhavNarayann
Added Collection List pagination
8e5a774
@VaibhavNarayann
Fix unit test filename typo
e705513
@VaibhavNarayann
Add locales
f552f4b
@VaibhavNarayann
Merge upstream/develop into feat/collection-list-pagination
db5b9b8
@VaibhavNarayann VaibhavNarayann mentioned this pull request May 7, 2026
Open
2 tasks
@yugalkaushik
Copy link
Copy Markdown
Contributor

yugalkaushik commented May 9, 2026

@VaibhavNarayann Thanks for working on this. Unfortunately, this PR is not in a reviewable state right now and does not meet the project standards for a focused contribution. There are too many unrelated changes in the branch, which makes it difficult to properly review and test the actual pagination work for this issue. I would recommend creating a fresh branch from the latest develop branch, understanding the issue requirements clearly, and opening a new PR containing only the minimal relevant changes for this feature. @ksen0 this PR can be closed.

@VaibhavNarayann
Copy link
Copy Markdown
Author

VaibhavNarayann commented May 10, 2026

Understood, thank you for the clear feedback. I'll open a fresh, focused PR shortly.

@VaibhavNarayann VaibhavNarayann deleted the feat/collection-list-pagination branch May 10, 2026 10:29
@VaibhavNarayann
Copy link
Copy Markdown
Author

VaibhavNarayann commented May 10, 2026

@yugalkaushik I created a fresh branch from the latest develop branch as suggested, but when I run the project locally I get this error:

image

I tried reinstalling node_modules but the error persists. Could you guide me on the correct setup steps to run the project locally on the develop branch?

Thank you!

@yugalkaushik
Copy link
Copy Markdown
Contributor

yugalkaushik commented May 10, 2026

@VaibhavNarayann Can I know what method you used to set up the project? Also, for installation-related doubts, it would be better to ask on Discord since you'll likely get a quicker response there from someone more familiar with the setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@VaibhavNarayann @yugalkaushik @khanniie @raclim @Vishawdeep-Singh @Geethegreat @kashish00208 @Nishthajain7