Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/inventory-queries
branch
from
6467a45 to
99dad9e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/inventory-queries
branch
from
ae043d7 to
011da57
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/inventory-queries
branch
from
6a0d9f1 to
ed5dfd0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/inventory-queries
branch
from
ed5dfd0 to
c5989cb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/inventory-queries
branch
from
c5989cb to
6f6a040
Compare
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/inventory-queries
branch
from
6f6a040 to
55a97d4
Compare
Benchmark for 07d2439Click to view benchmark
|
This doesn't yet implement inventory queries in the reference parser and the interpolation. Also, the interpolation order between parameters and exports is currently a guess.
The approach of only parsing inventory queries after resolving references probably won't work, since we don't know whether a query was escaped or not at that point. To do this properly, we'll have to extend / refactor the ref parser to become a ref+invquery parser.
Test coverage isn't great yet, and some inventory query features are not yet implemented.
…yreclass Not validated yet
Without this, `Exports::new()` has a very significant performance impact even for inventories that don't use inventory queries at all.
simu
force-pushed
the
feat/inventory-queries
branch
from
55a97d4 to
78da567
Compare
Benchmark for 851c079Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog
TODO