Skip to content

Replace deprecated PyO3 downcast* calls with equivalent cast* calls#191

Merged
simu merged 1 commit intomainfrom
pyo3/replace-deprecated-downcast
Nov 27, 2025
Merged

Replace deprecated PyO3 downcast* calls with equivalent cast* calls#191
simu merged 1 commit intomainfrom
pyo3/replace-deprecated-downcast

Conversation

@simu
Copy link
Copy Markdown
Member

@simu simu commented Nov 25, 2025

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related PRs or issues.

@github-actions

This comment was marked as outdated.

@simu simu force-pushed the feat/ignore-missing-overwritten-references branch from ded03b2 to 974108a Compare November 25, 2025 13:04
@simu simu force-pushed the pyo3/replace-deprecated-downcast branch from 21e1dd3 to 3b5aab0 Compare November 25, 2025 15:06
@github-actions

This comment was marked as outdated.

@simu simu force-pushed the feat/ignore-missing-overwritten-references branch from 5e7bb80 to de64609 Compare November 25, 2025 15:56
Base automatically changed from feat/ignore-missing-overwritten-references to main November 25, 2025 16:03
@simu simu force-pushed the pyo3/replace-deprecated-downcast branch from 3b5aab0 to b9d5280 Compare November 25, 2025 16:04
@simu simu requested a review from a team November 25, 2025 16:04
@simu
Copy link
Copy Markdown
Member Author

simu commented Nov 25, 2025

macOS 13 deprecation handled in #193

@github-actions

This comment was marked as outdated.

@simu simu force-pushed the pyo3/replace-deprecated-downcast branch from b9d5280 to 5871fe5 Compare November 25, 2025 16:19
@simu simu changed the base branch from main to ci/macos-15 November 25, 2025 16:21
@github-actions

This comment was marked as outdated.

Base automatically changed from ci/macos-15 to main November 27, 2025 12:09
@simu simu force-pushed the pyo3/replace-deprecated-downcast branch from 5871fe5 to 215688b Compare November 27, 2025 12:10
@simu simu enabled auto-merge November 27, 2025 12:10
@github-actions
Copy link
Copy Markdown

Benchmark for 34fb560

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 2.3±0.12ms 2.3±0.18ms 0.00%
Reclass::inventory() single-threaded 4.6±0.09ms 4.6±0.05ms 0.00%

@simu simu merged commit 4a4893e into main Nov 27, 2025
22 checks passed
@simu simu deleted the pyo3/replace-deprecated-downcast branch November 27, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants