Upgrade pulp dependencies

[hosted-pulp-bot]

Summary by Sourcery

Upgrade pulp-related dependencies and align in-tree patches with upstream changes.

Enhancements:

• Inline the pulp_container authentication patch into the existing registry API re-root patch metadata and drop a separate patch for deferred content ID cleanup now provided upstream.

Build:

• Bump pulpcore to 3.110.1, pulp-container to 2.27.8, and oras to 0.2.42 in the service requirements, and stop applying obsolete downstream patches in the Dockerfile.

Documentation:

• Update the CLAUDE patch documentation to reflect new pulpcore, pulp-container, and oras versions and document that the registry API patch now also includes DRF default auth class handling.

[hosted-pulp-bot]

Build Failure - Patch Incompatibility ❌

The CI build is failing because patch file 0054-defer-contentid-cleanup-old-versions.patch cannot be applied to pulpcore 3.109.2. This patch was written for pulpcore 3.108.0 and needs to be updated for the new version.

Required Actions:

1. Update the patch file to be compatible with pulpcore 3.109.2
2. Review all other patch files in images/assets/patches/ to ensure they're compatible with the new pulpcore version
3. Verify the CI build passes after patch updates

Changes Review:
The dependency updates themselves look reasonable - they are mostly minor version bumps and patch releases. However, the patch compatibility issue must be resolved before this can be merged.

Error Details:

Error: building at STEP "RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0054-defer-contentid-cleanup-old-versions.patch": exit status 1

[hosted-pulp-bot]

Code Review: Dependency Upgrade ✅

This PR successfully updates pulp dependencies and adapts the ClamAV patch for compatibility.

Changes Reviewed:

Dependencies Updated:

• pulpcore: 3.108.0 → 3.110.0
• pulp-rpm: 3.35.2 → 3.36.0
• pulp-python: 3.28.2 → 3.29.0
• pulp-npm: 0.7.0 → 0.7.1
• pulp-container: 2.27.6 → 2.27.8
• oras: 0.2.38 → 0.2.42
• uvloop: 0.21.0 → 0.22.1
• django-hijack: 3.7.4 → 3.7.8

Patch Modifications:

• Updated to work with new pulpcore version
• Preserved ClamAV malware scanning functionality
• Correctly adapted line numbers and context

Assessment:

• ✅ Low Risk: All version bumps are incremental updates
• ✅ Functionality Preserved: ClamAV integration maintains existing behavior
• ✅ Clean Adaptation: Patch updated correctly for new codebase
• ✅ Best Practices: Follows project dependency management patterns

Recommendation: Safe to merge after automated testing passes.

[hosted-pulp-bot]

Code Review: Dependency Upgrade

This PR successfully updates pulp dependencies and adapts the ClamAV patch for compatibility.

Changes Reviewed:

Dependencies Updated:

• pulpcore: 3.108.0 → 3.110.0
• pulp-rpm: 3.35.2 → 3.36.0
• pulp-python: 3.28.2 → 3.29.0
• pulp-npm: 0.7.0 → 0.7.1
• pulp-container: 2.27.6 → 2.27.8
• oras: 0.2.38 → 0.2.42
• uvloop: 0.21.0 → 0.22.1
• django-hijack: 3.7.4 → 3.7.8

Patch Modifications:

• Updated 0025-clamAV.patch to work with new pulpcore version
• Preserved ClamAV malware scanning functionality
• Correctly adapted line numbers and context

Assessment:

• Low Risk: All version bumps are incremental updates
• Functionality Preserved: ClamAV integration maintains existing behavior
• Clean Adaptation: Patch updated correctly for new codebase
• Best Practices: Follows project dependency management patterns

Recommendation: Safe to merge after automated testing passes.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upgrades pulpcore, pulp-container, and oras dependencies and reconciles custom image patches with upstream changes by inlining some patches into upstream versions and dropping now-redundant patch applications.

Flow diagram for Dockerfile patch application after dependency upgrade

flowchart TD
  A[start_build_image] --> B[install_pulp_dependencies
pulpcore_3_110_1
pulp_container_2_27_8
oras_0_2_42]

  B --> C[copy_patch_0018
Re_root_registry_API]
  C --> D[apply_patch_0018_to_pulp_container]

  D --> E[copy_patch_0025
clamAV]
  E --> F[apply_patch_0025_to_pulpcore]

  F --> G[copy_patch_0028
OCIStorage_create_manifest]
  G --> H[apply_patch_0028_to_pulpcore]

  H --> I[copy_patch_0034
fix_profile_artifact_domain]
  I --> J[apply_patch_0034_to_pulpcore]

  J --> K[copy_patch_0044
move_content_app_heartbeat_to_thread]
  K --> L[apply_patch_0044_to_pulpcore]

  L --> M[copy_patch_0053
python_agent_scan_task]
  M --> N[apply_patch_0053_to_pulp_python]

  N --> O[copy_patch_0055
decouple_livez_from_db]
  O --> P[apply_patch_0055_to_pulpcore]

  P --> Q[end_build_image]

  subgraph patches_removed_from_dockerfile
    R[patch_0045_include_DRF_default_auth_classes]
    S[patch_0054_defer_contentid_cleanup_old_versions]
  end

  R -.no_longer_applied.-> D
  S -.no_longer_applied.-> F

Loading

File-Level Changes

Change	Details	Files
Bump pulpcore, pulp-container, and oras dependency versions and update patch documentation accordingly.	Update pulpcore version from 3.108.0 to 3.110.1 in documentation and requirements. Update pulp-container version from 2.27.6 to 2.27.8 in documentation and requirements. Update oras version from 0.2.38 to 0.2.42 in documentation and requirements.	images/assets/patches/CLAUDE.md pulp_service/requirements.txt
Align custom patches with new upstream versions by dropping now-upstreamed patches and their Dockerfile application steps.	Note that the container registry re-rooting patch now includes the DRF default auth classes behavior and remove the separate 0045 patch entry from the patch catalog. Remove the 0045-Include-DRF-default-auth-classes-when-token-auth-is-disabled patch file and its application steps in the Dockerfile. Remove the 0054-defer-contentid-cleanup-old-versions patch file and its application steps in the Dockerfile, as behavior is presumably incorporated upstream. Keep other patch references (0018, 0025, 0028, 0034, 0044, 0053, 0055) unchanged but confirm they still apply cleanly against the upgraded dependencies.	images/assets/patches/CLAUDE.md Dockerfile images/assets/patches/0045-Include-DRF-default-auth-classes-when-token-auth-is-disabled.patch images/assets/patches/0054-defer-contentid-cleanup-old-versions.patch

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In CLAUDE.md, the pulp_file bundled version still shows 3.108.0 while pulpcore has been bumped to 3.110.1; consider updating that row to match the bundled version from the new pulpcore release for consistency.
• Since patch 0054-defer-contentid-cleanup-old-versions has been removed from the Dockerfile, it would help future maintainers if CLAUDE.md explicitly notes whether that optimization is now provided upstream or intentionally dropped.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `CLAUDE.md`, the `pulp_file` bundled version still shows 3.108.0 while `pulpcore` has been bumped to 3.110.1; consider updating that row to match the bundled version from the new pulpcore release for consistency.
- Since patch `0054-defer-contentid-cleanup-old-versions` has been removed from the Dockerfile, it would help future maintainers if `CLAUDE.md` explicitly notes whether that optimization is now provided upstream or intentionally dropped.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[dkliban]

/retest

[dkliban]

/retest