fix modsec_disable_ids, modsec_disable_msgs, modsec_disable_tags hand…#2620
Closed
bovy89 wants to merge 2 commits intopuppetlabs:mainfrom
Closed
fix modsec_disable_ids, modsec_disable_msgs, modsec_disable_tags hand…#2620bovy89 wants to merge 2 commits intopuppetlabs:mainfrom
bovy89 wants to merge 2 commits intopuppetlabs:mainfrom
Conversation
…ling; remove duplicated modsec_disable_vhost; change modsec_body_limit from string to integer
bovy89
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
Contributor
Author
|
Any update or feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change,
modsec_disable_ids,modsec_disable_msgs,modsec_disable_tagsparamenters are not used byapache/vhost/_security.epptemplate.Check on
modsec_disable_vhostparamenter is duplicated on the same if statement.modsec_body_limit type is wrong al lead to
modsec_body_limit => "123456"or even worstmodsec_body_limit => "${custom_body_limit}"instead of
modsec_body_limit => 123456,