Cleanup timer in signal blocker from the correct thread#649
Open
flowln wants to merge 1 commit intopytest-dev:masterfrom
Open
Cleanup timer in signal blocker from the correct thread#649flowln wants to merge 1 commit intopytest-dev:masterfrom
flowln wants to merge 1 commit intopytest-dev:masterfrom
Conversation
According to the PySide6 documentation on QTimer: Qt uses the timer’s thread affinity to determine which thread will emit the timeout() signal. Because of this, you must start and stop the timer in its thread; Because of that, we need to schedule the stop invokation to run in the timer's parent thread. Signed-off-by: Sofia Donato Ferreira <sofia.ferreira@lnls.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the PySide6 documentation on QTimer:
Because of that, we need to schedule the stop invokation to run in the timer's parent thread. This ensures correct behavior when handling signals emitted from different threads.