Fix multiline text line height calculation#9618
Open
mitre88 wants to merge 1 commit intopython-pillow:mainfrom
Open
Fix multiline text line height calculation#9618mitre88 wants to merge 1 commit intopython-pillow:mainfrom
mitre88 wants to merge 1 commit intopython-pillow:mainfrom
Conversation
The line spacing calculation was using only 'A' which doesn't account for characters that extend below the baseline (like 'p', 'g', 'y'). Using string.ascii_letters ensures we measure the full font height. Fixes python-pillow#1646
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line spacing calculation was using only 'A' which doesn't account for characters that extend below the baseline (like 'p', 'g', 'y'). Using
string.ascii_lettersensures we measure the full font height including both ascenders and descenders.Fixes #1646