fix: migrate bulk-import makeStyles to sx preventing JSS collisions#3090
Open
rohitratannagar wants to merge 1 commit intoredhat-developer:mainfrom
Open
fix: migrate bulk-import makeStyles to sx preventing JSS collisions#3090rohitratannagar wants to merge 1 commit intoredhat-developer:mainfrom
rohitratannagar wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com>
rohitratannagar
requested review from
a team,
debsmita1,
its-mitesh-kumar and
rm3l
as code owners
Changed Packages
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
==========================================
- Coverage 61.00% 61.00% -0.01%
==========================================
Files 2069 2069
Lines 64043 64036 -7
Branches 16620 16621 +1
==========================================
- Hits 39070 39065 -5
+ Misses 24740 24738 -2
Partials 233 233
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: CSS class name collision between bulk-import plugins and lightspeed
Issue
fixes: https://redhat.atlassian.net/browse/RHDHBUGS-2822
possible reason for the bug
makeStylesfrom@mui/styles(JSS), which generates global class names such asjss1,jss2, etc.1, causing identical class names across plugins.<head>, Lightspeed FAB's!importantstyles (position: fixed,backgroundColor,maxWidth) leaked into bulk-import table rows.Fix
makeStylesto MUI'ssxprop.sxuses Emotion, which generates content-hashed class names (css-*) instead of sequentialjss{n}classes.UI before changes
Screen.Recording.2026-05-10.at.12.07.12.AM.mov
UI after changes
Screen.Recording.2026-05-10.at.12.04.21.AM.mov
✔️ Checklist