fix: cap related-row fetch in RelatedActivityLogSource (#14)#19
Open
AsmitNepali wants to merge 1 commit into1.xfrom
Open
fix: cap related-row fetch in RelatedActivityLogSource (#14)#19AsmitNepali wants to merge 1 commit into1.xfrom
AsmitNepali wants to merge 1 commit into1.xfrom
Conversation
Add ->limit($window->cap) to related-row query to avoid loading all related rows into memory when only $window->cap activity entries are needed downstream. Matches existing cap on the activity-log query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14.
RelatedActivityLogSource::resolve()loaded all related rows into memory before querying the activity log, causing N+1 / memory blow-up for subjects with thousands of related rows (e.g., a Person with 10k tasks).Change
src/Timeline/Sources/RelatedActivityLogSource.php:36— add->limit($window->cap)to the related-row fetch so it matches the cap already applied to the activity-log query downstream.Test plan
tests/Feature/RelatedActivityLogSourceTest.phppasses (3 tests, 4 assertions)🤖 Generated with Claude Code