fix: remove dead 'date_groups' config key (#10)#22
Open
AsmitNepali wants to merge 1 commit into1.xfrom
Open
Conversation
Key never read by code. Buckets computed in ActivityLogLivewire::bucketFor. Update docs note to past-tense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10.
The
date_groupskey inconfig/activity-log.phpwas never read by application code — the timeline buckets are computed byActivityLogLivewire::bucketFor()and ignore config entirely. Shipping the key was misleading: users could set it and see no effect.Changes
config/activity-log.php: drop unuseddate_groupsarray.docs/content/3.essentials/6.configuration.md: update the "Removed key" note to past-tense now that the key is actually gone.Picked Option 1 from the issue (delete) over Option 2 (wire up) — lower risk, matches current behavior, and the docs were already steering users away from the key.
Test plan
php -l config/activity-log.php— no syntax errorsgrep -rn "date_groups" src/— zero references (confirms nothing broke)🤖 Generated with Claude Code