feat(kitchen-sink): add load testing harness#5017
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code Review: feat(kitchen-sink): add load testing harnessOverviewThis PR adds a comprehensive load testing harness to the kitchen-sink example:
Overall the PR is well-structured. A few issues worth addressing before merging. Bugs / Correctness1. Race condition in The message listener is async with no backpressure. A second message can arrive and increment 2. Magic string coupling for actor-stopped reconnect
Code Quality3. In 4.
5. Undocumented backward-compat alias
Dockerfile / Build Script6. Using 7. 7 GB heap default
8.
Minor
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: