Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
# Run `npm run bump` to bump the version and create a git tag.
push:
tags:
- "v*"
- 'v*'

workflow_dispatch:

Expand Down Expand Up @@ -46,4 +46,4 @@ jobs:
- name: Create GitHub Release
uses: ncipollo/release-action@339a81892b84b4eeb0f6e744e4574d79d0d9b8dd # v1
with:
generateReleaseNotes: "true"
generateReleaseNotes: 'true'
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: 24.14.1
cache: "pnpm"
cache: 'pnpm'

- name: Install Dependencies
run: pnpm install && npx playwright install
Expand Down
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Ignore artifacts:
dist
pnpm-lock.yaml
3 changes: 3 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"singleQuote": true
}
2 changes: 1 addition & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"recommendations": ["biomejs.biome"]
"recommendations": ["rstack.rslint", "esbenp.prettier-vscode"]
}
16 changes: 1 addition & 15 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,4 @@
{
"search.useIgnoreFiles": true,
"[json]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[typescript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[javascript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[javascriptreact]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[css]": {
"editor.defaultFormatter": "biomejs.biome"
}
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Add plugin to your `rsbuild.config.ts`:

```ts
// rsbuild.config.ts
import { pluginEjs } from "rsbuild-plugin-ejs";
import { pluginEjs } from 'rsbuild-plugin-ejs';

export default {
plugins: [pluginEjs()],
Expand All @@ -37,7 +37,7 @@ For example, first create a `src/index.ejs` file, and point to that file using `
```ts title="rsbuild.config.ts"
export default {
html: {
template: "./src/index.ejs",
template: './src/index.ejs',
},
};
```
Expand Down Expand Up @@ -74,7 +74,7 @@ const defaultOptions = {
```ts
pluginEjs({
ejsOptions: {
delimiter: "|",
delimiter: '|',
},
});
```
Expand Down
31 changes: 0 additions & 31 deletions biome.json

This file was deleted.

19 changes: 8 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,32 +11,29 @@
}
},
"types": "./dist/index.d.ts",
"files": ["dist"],
"files": [
"dist"
],
"scripts": {
"build": "rslib",
"dev": "rslib -w",
"lint": "biome check .",
"lint:write": "biome check . --write",
"lint": "rslint && prettier -c .",
"lint:write": "rslint --fix && prettier -w .",
"prepare": "simple-git-hooks && npm run build",
"test": "playwright test",
"bump": "npx bumpp"
},
"simple-git-hooks": {
"pre-commit": "npx nano-staged"
},
"nano-staged": {
"*.{js,jsx,ts,tsx,mjs,cjs}": [
"biome check --write --no-errors-on-unmatched"
]
"pre-commit": "pnpm run lint:write"
},
Comment on lines 26 to 28
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit now runs pnpm run lint:write, which formats/lints the entire repo (not just staged files). This can be slow and can modify unstaged working-tree changes without re-staging them, leading to confusing commits. Consider switching back to a staged-files workflow (e.g., lint-staged/nano-staged equivalent) or compute the staged file list and pass it to rslint/prettier, then re-stage modified files.

Copilot uses AI. Check for mistakes.
"devDependencies": {
"@biomejs/biome": "^1.9.4",
"@playwright/test": "^1.59.1",
"@rsbuild/core": "^1.7.5",
"@rslib/core": "^0.21.0",
"@rslint/core": "0.4.1",
"@types/node": "^24.12.2",
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslint.config.ts is TypeScript, but @rslint/core declares jiti as a (optional) peer dependency for config loading. Since jiti is not declared in devDependencies, this setup can break if jiti stops being present transitively. Either add jiti explicitly or switch the config to a JS file to avoid the TS runtime requirement.

Suggested change
"@types/node": "^24.12.2",
"@types/node": "^24.12.2",
"jiti": "^2.4.2",

Copilot uses AI. Check for mistakes.
"nano-staged": "^1.0.2",
"playwright": "^1.59.1",
"prettier": "^3.8.1",
"simple-git-hooks": "^2.13.1",
"typescript": "6.0.2"
},
Expand Down
Loading
Loading