-
Notifications
You must be signed in to change notification settings - Fork 0
chore: migrate from biome to prettier and rslint #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Ignore artifacts: | ||
| dist | ||
| pnpm-lock.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "singleQuote": true | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "recommendations": ["biomejs.biome"] | ||
| "recommendations": ["rstack.rslint", "esbenp.prettier-vscode"] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,4 @@ | ||
| { | ||
| "search.useIgnoreFiles": true, | ||
| "[json]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[typescript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[javascript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[javascriptreact]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[css]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| } | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| } |
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,32 +11,29 @@ | |||||||
| } | ||||||||
| }, | ||||||||
| "types": "./dist/index.d.ts", | ||||||||
| "files": ["dist"], | ||||||||
| "files": [ | ||||||||
| "dist" | ||||||||
| ], | ||||||||
| "scripts": { | ||||||||
| "build": "rslib", | ||||||||
| "dev": "rslib -w", | ||||||||
| "lint": "biome check .", | ||||||||
| "lint:write": "biome check . --write", | ||||||||
| "lint": "rslint && prettier -c .", | ||||||||
| "lint:write": "rslint --fix && prettier -w .", | ||||||||
| "prepare": "simple-git-hooks && npm run build", | ||||||||
| "test": "playwright test", | ||||||||
| "bump": "npx bumpp" | ||||||||
| }, | ||||||||
| "simple-git-hooks": { | ||||||||
| "pre-commit": "npx nano-staged" | ||||||||
| }, | ||||||||
| "nano-staged": { | ||||||||
| "*.{js,jsx,ts,tsx,mjs,cjs}": [ | ||||||||
| "biome check --write --no-errors-on-unmatched" | ||||||||
| ] | ||||||||
| "pre-commit": "pnpm run lint:write" | ||||||||
| }, | ||||||||
| "devDependencies": { | ||||||||
| "@biomejs/biome": "^1.9.4", | ||||||||
| "@playwright/test": "^1.59.1", | ||||||||
| "@rsbuild/core": "^1.7.5", | ||||||||
| "@rslib/core": "^0.21.0", | ||||||||
| "@rslint/core": "0.4.1", | ||||||||
| "@types/node": "^24.12.2", | ||||||||
|
||||||||
| "@types/node": "^24.12.2", | |
| "@types/node": "^24.12.2", | |
| "jiti": "^2.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commitnow runspnpm run lint:write, which formats/lints the entire repo (not just staged files). This can be slow and can modify unstaged working-tree changes without re-staging them, leading to confusing commits. Consider switching back to a staged-files workflow (e.g., lint-staged/nano-staged equivalent) or compute the staged file list and pass it to rslint/prettier, then re-stage modified files.