Skip to content

chore: migrate linting to rslint and prettier#52

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier
Apr 28, 2026
Merged

chore: migrate linting to rslint and prettier#52
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

This PR migrates the repository linting and formatting setup from Biome to Rslint plus Prettier, matching the rsbuild plugin template. It updates npm scripts, pre-commit hooks, editor recommendations, and lockfile entries, then applies Prettier formatting across the files covered by the new lint command.

Copilot AI review requested due to automatic review settings April 28, 2026 09:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Migrates the repo’s linting/formatting toolchain from Biome to Rslint + Prettier, aligning configs and editor/tooling setup with the rsbuild plugin template.

Changes:

  • Add Rslint + Prettier configuration and update package.json scripts/hooks accordingly
  • Remove Biome config and adjust VS Code extension/formatter recommendations
  • Apply Prettier-driven formatting updates across docs/config files touched by the new lint command

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rslint.config.ts Introduces the Rslint config using the TypeScript recommended preset.
package.json Replaces Biome scripts/devDeps with Rslint + Prettier and updates hooks.
biome.json Removes the old Biome configuration file.
README.md Reformats code samples to match Prettier/single-quote style.
.vscode/settings.json Switches the default formatter to Prettier.
.vscode/extensions.json Recommends Rslint + Prettier VS Code extensions.
.prettierrc Adds Prettier config (single quotes).
.github/workflows/test.yml Formatting-only change to YAML quoting.
.github/workflows/release.yml Formatting-only change to YAML quoting.
.github/renovate.json5 Formats renovate config to JSON5 style / single quotes.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread package.json
Comment thread package.json
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 670dd3f92b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@chenjiahan chenjiahan merged commit f7e7c0a into main Apr 28, 2026
7 of 9 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/migrate-rslint-prettier branch April 28, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants