Skip to content

docs: Add Kotlin language standards (#33)#34

Merged
yokuze merged 1 commit intosilvermine:masterfrom
jjhafer:33_add_kotlin_standards
Apr 7, 2026
Merged

docs: Add Kotlin language standards (#33)#34
yokuze merged 1 commit intosilvermine:masterfrom
jjhafer:33_add_kotlin_standards

Conversation

@jjhafer
Copy link
Copy Markdown
Contributor

@jjhafer jjhafer commented Jul 26, 2025

Document our Kotlin language standards for upcoming projects.

  • Add kotlin.md and reference it in coding-standards.md.

@jjhafer jjhafer force-pushed the 33_add_kotlin_standards branch from d82d00c to ccbad26 Compare July 26, 2025 17:15
@jjhafer
Copy link
Copy Markdown
Contributor Author

jjhafer commented Jul 28, 2025

@yokuze @velocitysystems Could you review this MR? Similar to the Swift standards, @velocitysystems can you consult with App Dev and come back with any suggestions on the Kotlin standards? And @yokuze, please verify that this matches what you expect in the repo?

@yokuze yokuze requested review from velocitysystems and yokuze July 29, 2025 22:11
@yokuze yokuze self-assigned this Jul 29, 2025
yokuze
yokuze previously approved these changes Jul 29, 2025
Copy link
Copy Markdown
Contributor

@yokuze yokuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you get any PR comments to address, then you could add trailing . to the bullet points in the first couple sections to match the last few sections, or vice-versa, but that's super minor and not worth your time unless you're already pushing.

Structure and content LGTM, but leaving the full content review up to @velocitysystems

Copy link
Copy Markdown

@mnkyby78 mnkyby78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - this is my first review directly in Github. See my comments on the file itself.

Comment thread coding-standards/kotlin.md Outdated
Comment thread coding-standards/kotlin.md Outdated
Comment thread coding-standards/kotlin.md
Comment thread coding-standards/kotlin.md
Comment thread coding-standards/kotlin.md Outdated
@jjhafer jjhafer force-pushed the 33_add_kotlin_standards branch 2 times, most recently from 3635f8e to ab43680 Compare March 18, 2026 22:12
@jjhafer jjhafer requested a review from velocitysystems March 18, 2026 22:12
@jjhafer jjhafer force-pushed the 33_add_kotlin_standards branch from ab43680 to 82cdea0 Compare March 18, 2026 22:29
Comment thread coding-standards/kotlin.md
Comment thread coding-standards/kotlin.md
@jjhafer jjhafer force-pushed the 33_add_kotlin_standards branch from 82cdea0 to 2fd1c9c Compare March 23, 2026 17:28
@jjhafer jjhafer requested a review from velocitysystems March 23, 2026 17:28
Comment thread coding-standards/kotlin.md
Comment thread coding-standards/kotlin.md Outdated
Comment thread coding-standards/kotlin.md
Document our Kotlin language standards for upcoming
projects.

* Add `kotlin.md` and reference it in `coding-standards.md`.
@jjhafer jjhafer force-pushed the 33_add_kotlin_standards branch from 2fd1c9c to af12527 Compare April 7, 2026 14:01
@jjhafer jjhafer requested a review from yokuze April 7, 2026 14:06
@jjhafer
Copy link
Copy Markdown
Contributor Author

jjhafer commented Apr 7, 2026

@yokuze I resolved the issues reported by @velocitysystems. Can you merge?

@yokuze yokuze merged commit a607ea4 into silvermine:master Apr 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants