Skip to content

feat(php): drop support for EOLed PHP versions and unify min required version#2

Closed
simPod wants to merge 2 commits intomasterfrom
php/eol
Closed

feat(php): drop support for EOLed PHP versions and unify min required version#2
simPod wants to merge 2 commits intomasterfrom
php/eol

Conversation

@simPod
Copy link
Copy Markdown
Owner

@simPod simPod commented Feb 8, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@simPod simPod force-pushed the php/eol branch 4 times, most recently from e76f7f2 to dc90a76 Compare April 29, 2024 08:23
@simPod simPod changed the title feat(php): drop support for EOLed PHP versions and unify min required… feat(php): drop support for EOLed PHP versions and unify min required version Mar 23, 2025
zakupower and others added 2 commits March 23, 2025 18:31
… for Multipart requests when useBeanValidation=true (OpenAPITools#20864)

* [kotlin-spring] Generate @Valid annotation on all RequestParts/Params for Multipart requests when useBeanValidation=true

* [kotlin-spring] Fix failing test

The test was failing because of the newly added @Valid and an assert which is not correct anymore.
@simPod simPod closed this Mar 23, 2025
@simPod simPod deleted the php/eol branch March 24, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants