Skip to content

[AI-8th] Refine structured logging behavior for SOFABoot and SOFATracer#1419

Open
pmupkin wants to merge 1 commit intosofastack:masterfrom
pmupkin:spring-boot-log
Open

[AI-8th] Refine structured logging behavior for SOFABoot and SOFATracer#1419
pmupkin wants to merge 1 commit intosofastack:masterfrom
pmupkin:spring-boot-log

Conversation

@pmupkin
Copy link
Copy Markdown

@pmupkin pmupkin commented Apr 23, 2026

This PR(Related issue #1402) improves the initial structured logging support introduced for SOFABoot.

It tightens the behavior of the custom Logback structured encoder so that invalid structured logging configuration is no longer silently downgraded to pattern logging. It also adjusts the SOFATracer integration logic to avoid enabling tracer structured output based on console-only structured logging settings, which could otherwise lead to mixed log formats between SOFABoot file logs and tracer logs.

Overall, the changes make structured logging behavior more predictable, safer, and more consistent with user configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.96%. Comparing base (459b02f) to head (ab1b3bf).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../logging/logback/SofaBootStructuredLogEncoder.java 85.36% 0 Missing and 6 partials ⚠️
...figure/tracer/SofaTracerConfigurationListener.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1419      +/-   ##
============================================
+ Coverage     82.94%   82.96%   +0.01%     
- Complexity     2975     2995      +20     
============================================
  Files           340      341       +1     
  Lines          9833     9884      +51     
  Branches       1178     1183       +5     
============================================
+ Hits           8156     8200      +44     
  Misses         1163     1163              
- Partials        514      521       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant