[AI-8th] Refine structured logging behavior for SOFABoot and SOFATracer#1419
Open
pmupkin wants to merge 1 commit intosofastack:masterfrom
Open
[AI-8th] Refine structured logging behavior for SOFABoot and SOFATracer#1419pmupkin wants to merge 1 commit intosofastack:masterfrom
pmupkin wants to merge 1 commit intosofastack:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1419 +/- ##
============================================
+ Coverage 82.94% 82.96% +0.01%
- Complexity 2975 2995 +20
============================================
Files 340 341 +1
Lines 9833 9884 +51
Branches 1178 1183 +5
============================================
+ Hits 8156 8200 +44
Misses 1163 1163
- Partials 514 521 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR(Related issue #1402) improves the initial structured logging support introduced for SOFABoot.
It tightens the behavior of the custom Logback structured encoder so that invalid structured logging configuration is no longer silently downgraded to pattern logging. It also adjusts the SOFATracer integration logic to avoid enabling tracer structured output based on console-only structured logging settings, which could otherwise lead to mixed log formats between SOFABoot file logs and tracer logs.
Overall, the changes make structured logging behavior more predictable, safer, and more consistent with user configuration.