Replace thread-unsafe SimpleDateFormat with DateTimeFormatter in AbstractMockHttpServletRequestBuilder#36749
Closed
SebTardif wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
The static SimpleDateFormat instance in AbstractMockHttpServletRequestBuilder is shared across all instances. SimpleDateFormat.format() mutates internal Calendar state and is not thread-safe, which can produce corrupt date strings or ArrayIndexOutOfBoundsException when tests run in parallel. Replace with DateTimeFormatter which is immutable and thread-safe. Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>
SebTardif
force-pushed
the
fix/thread-unsafe-simpledateformat-mock-request
branch
from
63a14f6 to
a8bf3c1
Compare
bclozel
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the static
SimpleDateFormatinstance with a thread-safeDateTimeFormatterinAbstractMockHttpServletRequestBuilder.Problem
A
static final SimpleDateFormatis shared across all test request builder instances.SimpleDateFormat.format()mutates internalCalendarstate and is not thread-safe. When tests run in parallel (e.g., with JUnit's@Execution(CONCURRENT)), concurrent calls toheader(name, dateValue)can produce corrupt date strings or throwArrayIndexOutOfBoundsException.Fix
Replace with
DateTimeFormatter.ofPattern(...)using the same pattern (EEE, dd MMM yyyy HH:mm:ss zzz), locale (US), and timezone (UTC).DateTimeFormatteris immutable and thread-safe by design.