chore: align outliers in _tools/lint with namespace majority patterns#11835
Merged
chore: align outliers in _tools/lint with namespace majority patterns#11835
_tools/lint with namespace majority patterns#11835Conversation
…ions
Normalize `clbk` JSDoc type from `{Function}` to `{Callback}` in
`lib/async.js` to match the convention used by 7/8 (87.5%) sibling
packages in `_tools/lint`. The package's own `lib/lint.js` already
uses `{Callback}`, so this also fixes an internal inconsistency.
https://claude.ai/code/session_01UD2CQnJzjycfDbQ5DF4R96
_tools/lint with namespace JSDoc conventions---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Added the missing `test/test.js` smoke test (present in 89% of siblings in `_tools/lint/*`), verifying the main export is a function and exposes a `.sync` method. https://claude.ai/code/session_01AUoXAip8PZ8HxKqdgZi98C
_tools/lint with namespace majority patterns
Contributor
Coverage ReportNo coverage information available. |
…ace-aliases/test/test.js` The `Lint Copyright Years` workflow checks newly-added files for the current year in the copyright notice. Bumping from 2018 (which appears to have been carried over from the boilerplate) to 2026. https://claude.ai/code/session_01UD2CQnJzjycfDbQ5DF4R96
_tools/lint with namespace majority patterns_tools/lint with namespace majority patterns
Member
|
/stdlib merge |
…ools-lint-2026-04-29
kgryte
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligning outliers in
_tools/lintwith namespace majority patterns (random namespace pick, seed20260429).Namespace summary
filenames,header-filenames,license-header,license-header-file-list,license-header-glob,namespace-aliases,pkg-json,pkg-json-names,repl-txt)package.jsonshape, README sections (set + ordered), test/benchmark/example file naming, public signature, validation prologue, error construction, JSDoc shape,@stdlib/*dependencies, return kind(options, clbk), validation prologueclbk: isFunction, error constructionformat, JSDochasExampletrue, return kindvoid, dependency core (@stdlib/string/format,@stdlib/assert/is-string,@stdlib/assert/is-function,@stdlib/assert/is-plain-object,@stdlib/utils/define-nonenumerable-read-only-property,@stdlib/process/cwd,@stdlib/assert/has-own-property)package.jsonscripts/stdlibkeys (universally empty in this_tools/*namespace — no signal), benchmark file conventions (nobenchmark/directories present)pkg-json-namesFixes
_tools/lint/pkg-json-names/lib/async.jsline 47, where the@paramtype forclbkwas{Function}rather than{Callback}. The{Callback}JSDoc type is the established convention in 7 of 9 (78%)_tools/lint/*siblings.namespace-aliasesAdds
test/test.jsto_tools/lint/namespace-aliases, bringing it in line with the 89% majority pattern across the_tools/lintnamespace (8 of 9 siblings). The smoke test asserts the main export is a function exposing a.syncmethod, matching the boilerplate established in_tools/lint/filenamesand_tools/lint/pkg-json.Validation
Checked:
package.jsonkeys/scripts/stdlib, README L2/L3 sections, manifest shape, test/benchmark/example file naming).lib/main.js/lib/index.js/lib/validate.js(signature, return kind, validation prologue, error construction, JSDoc shape, dependencies).Deliberately excluded:
license-headerdeviating onreturnKind/publicSignature— intentional (sync string-blob primitive).license-header-file-listdeviating onpublicSignature— intentional (positional file list is the API contract).license-header-globandnamespace-aliasesmissingtest/fixtures/stdin_error.js.txt— neither CLI consumes stdin.license-headermissinglib/sync.js/lib/validate.js/test counterparts — async/sync split inapplicable to a synchronous primitive.license-header-file-listmissinglib/validate.js— validation is inlined inmain.jsby design.pkg-jsonandrepl-txtempty<section class="notes">— placeholders need package-specific content authoring (no mechanical fix).namespace-aliasesmissingtest/test.sync.js— a meaningful test would require fixtures the package lacks.namespace-aliasesmissing@stdlib/process/cwddependency — package resolves a stdlib root via internallib/root.js, intentional.The full audit (per-feature majorities, conformance percentages, every outlier and the reason it was kept or dropped) is preserved in a local drift report alongside the seed (
20260429) for reproducibility.Related Issues
None.
Questions
None.
Other
This PR is intentionally narrow — only two drift corrections survived three-agent validation in this namespace, and they sit on disjoint outlier packages.
Checklist
AI Assistance
Yes
No
Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding
Disclosure
This PR was authored by Claude (Anthropic) running an automated cross-package API drift detection routine: a structural + semantic feature pass over the namespace, majority-vote analysis at a 75% threshold, three-agent validation of every candidate, and mechanical alignment for the outliers that survived.
@stdlib-js/reviewers
Generated by Claude Code