fix: resolve JavaScript lint errors#11963
fix: resolve JavaScript lint errors#11963nathanaelmbale wants to merge 1 commit intostdlib-js:developfrom
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
|
||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| bool = isReadableProperty( arr, i ); |
There was a problem hiding this comment.
Changing new Array(100) to an empty array [] changes the test behavior significantly. With an empty array, all indices are non-existent properties, so isReadableProperty() will always return false. This doesn't reflect real-world usage and distorts the benchmark results. Should we keep the original length?
Resolves #11958.
Description
@stdlib/blas/base/sgertest filenew Array()constructor with an array literal in@stdlib/assert/is-readable-propertybenchmark fileRelated Issues
Questions
Other
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers