Skip to content

build: move package.json validation to make recipe#9520

Open
Planeshifter wants to merge 3 commits intodevelopfrom
philipp/move-pkg-json-validation-to-make
Open

build: move package.json validation to make recipe#9520
Planeshifter wants to merge 3 commits intodevelopfrom
philipp/move-pkg-json-validation-to-make

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented Jan 3, 2026 •
edited
Loading

Resolves stdlib-js/metr-issue-tracker#62.

Description

What is the purpose of this pull request?

This pull request:

  • separates the package.json metadata validation from the package.json linting
  • adds a new make recipe for validating all package.json files that might need to have their metadata updated for a list of files
  • adds package.json metadata validation to pre-commit hook

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@Planeshifter
Copy link
Copy Markdown
Member Author

Planeshifter commented Jan 3, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 3, 2026
@stdlib-js stdlib-js deleted a comment from stdlib-bot Jan 3, 2026
@Planeshifter Planeshifter force-pushed the philipp/move-pkg-json-validation-to-make branch from c3c09bb to f02bd2a Compare January 3, 2026 19:28
@Planeshifter
Copy link
Copy Markdown
Member Author

Planeshifter commented Jan 3, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 3, 2026
@Planeshifter Planeshifter marked this pull request as ready for review January 3, 2026 19:32
@Planeshifter Planeshifter requested a review from kgryte January 3, 2026 19:33
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 3, 2026
@kgryte kgryte added Tools Issue or pull request related to project tooling. and removed Needs Review A pull request which needs code review. labels Jan 5, 2026
kgryte
kgryte reviewed Jan 5, 2026
View reviewed changes
Comment thread tools/make/lib/lint/package_json.mk Outdated
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Jan 5, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jan 5, 2026

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 5, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jan 6, 2026

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 6, 2026
@Planeshifter
build: move package.json validation to make recipe
8c1fd92 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter force-pushed the philipp/move-pkg-json-validation-to-make branch from 8f6f49b to 7a6fe39 Compare March 16, 2026 04:25
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 16, 2026 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@Planeshifter
build: rename validate-pkg-json to lint-pkgs-metadata-files and move …
ab4986a 
…to lint/pkgs

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: passed
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter force-pushed the philipp/move-pkg-json-validation-to-make branch from 7a6fe39 to ab4986a Compare March 16, 2026 04:28
Planeshifter
Planeshifter commented Mar 16, 2026
View reviewed changes
Comment thread tools/make/lib/lint/pkgs/Makefile Outdated
Comment thread tools/git/hooks/pre-commit
Comment thread tools/git/hooks/pre-commit Outdated
@Planeshifter
chore: minor clean-up
6cb79ac 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter requested a review from kgryte March 16, 2026 04:40
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte Awaiting requested review from kgryte

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review A pull request which needs code review. Tools Issue or pull request related to project tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Move the ⁠package.json file CI lint check into a ⁠make recipe and add to pre-commit hook

3 participants

@Planeshifter @kgryte @stdlib-bot