Skip to content

Fixes to benchmark test code due to missing updates in dependency methods #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenya-sk wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fixes to benchmark test code due to missing updates in dependency methods #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4a5b2c4
add: py_library for test execution
kenya-sk Apr 6, 2026
92d2ffc
change: reimplement unavailable method
kenya-sk Apr 6, 2026
8ece8f9
chore: file format
kenya-sk Apr 6, 2026
814bec2
change: generate random circuit by recirq implementation
kenya-sk Apr 6, 2026
bf27725
delete: unnecessary debug log
kenya-sk Apr 6, 2026
f1e342f
change: method for random sequence selection
kenya-sk May 6, 2026
8fe8aed
change: get qubits befor iteration
kenya-sk May 6, 2026
45d1a63
change: resolved conflict
kenya-sk May 6, 2026
22e8ce6
fix: lint error
kenya-sk May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions benchmarks/scripts/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,19 @@ licenses(["notice"])
# Export for the PIP package.
exports_files(["__init__.py"])

py_library(
name = "benchmark_flags",
srcs = ["flags.py"],
)

py_test(
name = "benchmark_clifford_circuit",
srcs = ["benchmark_clifford_circuit.py"],
python_version = "PY3",
deps = [
":benchmark_flags",
":benchmark_util",
"//benchmarks/scripts/models:random_clifford_circuit",
"//tensorflow_quantum/core/ops:tfq_simulate_ops_py",
"//tensorflow_quantum/core/serialize:serializer",
"@local_config_tf//:test_log_pb2",
Expand All @@ -35,6 +43,8 @@ py_test(
srcs = ["benchmark_random_circuit.py"],
python_version = "PY3",
deps = [
":benchmark_flags",
":benchmark_util",
"//tensorflow_quantum/core/ops:tfq_simulate_ops_py",
"//tensorflow_quantum/core/serialize:serializer",
"@local_config_tf//:test_log_pb2",
Expand All @@ -46,6 +56,8 @@ py_test(
srcs = ["benchmark_op_gradients.py"],
python_version = "PY3",
deps = [
":benchmark_flags",
":benchmark_util",
"//tensorflow_quantum/core/ops:batch_util",
"//tensorflow_quantum/core/ops:cirq_ops",
"//tensorflow_quantum/core/ops:tfq_simulate_ops_py",
Expand Down
8 changes: 4 additions & 4 deletions benchmarks/scripts/benchmark_op_gradients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def setup(self):
for resolver in resolver_batch],
dtype=np.float32)

self.symbol_names = symbol_names
self.symbol_names_tensor = tf.convert_to_tensor(symbol_names)
self.symbol_values_tensor = tf.convert_to_tensor(symbol_values_array)
self.programs = util.convert_to_tensor(circuit_batch)
self.psums = util.convert_to_tensor([psums])
Expand All @@ -140,15 +140,15 @@ def _benchmark_tfq_differentiator(self, differentiator, params):
analytic_op=tfq_simulate_ops.tfq_simulate_expectation)

for _ in range(params.n_burn):
op(self.programs, self.symbol_names, self.symbol_values_tensor,
self.psums)
op(self.programs, self.symbol_names_tensor,
self.symbol_values_tensor, self.psums)

deltas = [None] * params.n_runs
for i in range(params.n_runs):
start = time.perf_counter()
with tf.GradientTape() as g:
g.watch(self.symbol_values_tensor)
expectations = op(self.programs, self.symbol_names,
expectations = op(self.programs, self.symbol_names_tensor,
self.symbol_values_tensor, self.psums)
g.gradient(expectations, self.symbol_values_tensor)
deltas[i] = time.perf_counter() - start
Expand Down
Loading
Loading