Skip to content

Replace instances of "vertical ellipsis" with "options icon"#4811

Open
jsvarova wants to merge 6 commits intotheforeman:masterfrom
jsvarova:SAT-28799-options-menu
Open

Replace instances of "vertical ellipsis" with "options icon"#4811
jsvarova wants to merge 6 commits intotheforeman:masterfrom
jsvarova:SAT-28799-options-menu

Conversation

@jsvarova
Copy link
Copy Markdown

@jsvarova jsvarova commented May 4, 2026

As per discussion at https://community.theforeman.org/t/how-to-refer-to-kebab-menus/45994?u=maximilian Implemented Maxmilian's and Lena's feedback.

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026 •
edited
Loading

The PR preview for 167aac3 is available at theforeman-foreman-documentation-preview-pr-4811.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@jsvarova jsvarova requested a review from maximiliankolb May 4, 2026 17:22
@jsvarova
Copy link
Copy Markdown
Author

jsvarova commented May 4, 2026

Hope I got it right this time.
Kindly asking @maximiliankolb for a review.
Thanks a lot, jana

maximiliankolb
maximiliankolb reviewed May 5, 2026
View reviewed changes
Comment thread guides/common/modules/proc_enabling-and-disabling-repositories-on-hosts.adoc Outdated
Comment thread guides/common/modules/proc_removing-a-package-from-a-host.adoc Outdated
@maximiliankolb maximiliankolb removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels May 5, 2026
jsvarova and others added 3 commits May 5, 2026 09:07
@jsvarova @maximiliankolb
Implement style feedback in a procedure
355176c 
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
@jsvarova @maximiliankolb
Shorten a procedural step
b91f2e2 
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
Fix a vale error (Use 'upgradeable' rather than 'upgradable)
dbb487b
maximiliankolb
maximiliankolb approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM style-wise.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels May 5, 2026
@apinnick
Copy link
Copy Markdown
Contributor

apinnick commented May 5, 2026

I believe that should be "options menu", not "options icon". See comment.

@jsvarova
Copy link
Copy Markdown
Author

jsvarova commented May 5, 2026

Hello @apinnick , let me rephrase the instances, then. Style-wise, I believe these phrases are best for the SAT docs.

"Open the options menu"
"Select [item] from the options menu"

Do you agree, @maximiliankolb ?
Thanks a lot, jana

@maximiliankolb
Copy link
Copy Markdown
Contributor

maximiliankolb commented May 5, 2026

I suggest From the options menu, select *X*.

Lennonka
Lennonka reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lennonka Lennonka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks. The rest is acceptable.

Or did you have larger changes in mind?

Comment thread guides/common/modules/proc_adding-a-host-to-a-host-collection-by-using-web-ui.adoc Outdated
Comment thread guides/common/modules/proc_synchronizing-insights-recommendations-for-hosts.adoc Outdated
@Lennonka Lennonka added Waiting on contributor Requires an action from the author Needs style review Requires a review from docs style/grammar perspective and removed style review done No issues from docs style/grammar perspective labels May 5, 2026
@jsvarova @Lennonka
Replace icon with menu
140ac9b 
Co-authored-by: Lena Ansorgová <zuansorg@redhat.com>
@pr-processor pr-processor Bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels May 6, 2026
@jsvarova @Lennonka
Replace icon with menu 2
167aac3 
Co-authored-by: Lena Ansorgová <zuansorg@redhat.com>
@jsvarova
Copy link
Copy Markdown
Author

jsvarova commented May 6, 2026 •
edited
Loading

Hello @Lennonka ,

well, I actually thought of replacing ALL the instances. I see a couple of procedural steps that might also benefit from splitting into two and some ugly iteration of "click", for instance:

  • Select the desired number of repositories or click the Select All checkbox to select all repositories, then click the options icon, and select Override to Enabled.
  • Click the options icon and click Copy.
    I'll fix it tonight. Cheers, jana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lennonka Lennonka Lennonka left review comments

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees

No one assigned

Labels

Needs re-review Needs style review Requires a review from docs style/grammar perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsvarova @apinnick @maximiliankolb @Lennonka