chore: drop unused dev dependencies#53
Merged
jasonbosco merged 2 commits intotypesense:masterfrom Apr 30, 2026
Merged
Conversation
Remove four dev dependencies that are not referenced anywhere in the gem, its specs, the Rakefile, the Guardfile, the bin/ scripts, the examples, or the CI workflow: - `codecov` (~> 0.1): Officially deprecated by Codecov in 2021 in favour of the Codecov uploader binary / GitHub Action. The current `.github/workflows/tests.yml` uploads the simplecov report as a GitHub artifact and never invokes the codecov gem. - `rspec-legacy_formatters` (~> 1.0): The Gemfile comment states it was only there for the codecov formatter. Drops with codecov. - `rspec_junit_formatter` (~> 0.4): The CI workflow runs `bundle exec rspec --format documentation` and produces no JUnit XML, so this formatter has no consumer. - `erb`: The standalone gem has no consumer in the project. ERB is in the Ruby stdlib for the supported matrix (>= 2.7), and `require 'erb'` is not used anywhere in the gem. Verified: full RSpec suite (151 examples, 1 failure - pre-existing `truncate_len` integration failure on master, unrelated to this change) and `bundle exec rubocop` (97 files, no offenses) both green after the removal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
erimicel
changed the title
tharropoulos
approved these changes
Apr 28, 2026
Member
|
Could you resolve the conflicts in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes four dev dependencies from the
Gemfilethat are not referenced anywhere in the gem code, specs,Rakefile,Guardfile,bin/,examples/, or the CI workflow.codecov(~> 0.1).github/workflows/tests.ymluploads the simplecov report as a GitHub artifact and never requires/invokes the codecov gem.rspec-legacy_formatters(~> 1.0)rspec_junit_formatter(~> 0.4)bundle exec rspec --format documentationand produces no JUnit XML, so this formatter has no consumer.erbrequire 'erb'anywhere in the gem. ERB is in the Ruby stdlib for the supported matrix (>= 2.7), so the standalone gem entry was redundant.awesome_print,guard,guard-rubocop, and the rest are kept untouched —awesome_printis used heavily inexamples/, andguard/guard-rubocopare wired up inGuardfilefor local rubocop-on-save.Verification
bundle install— resolves cleanly, 12 Gemfile deps (was 16), 61 gems total (was 68).bundle exec rubocop— 97 files inspected, no offenses.bundle exec rspec— 151 examples, 1 failure, 27 pending. The single failure iscollections_spec.rb:156(truncate_lenschema mismatch with the running Typesense container) — pre-existing onmaster, unrelated to this change.PR Checklist