meld: make dropping memo/ford persistent tables optional#1006
Open
dozreg-toplud wants to merge 4 commits intodevelopfrom
Open
meld: make dropping memo/ford persistent tables optional#1006dozreg-toplud wants to merge 4 commits intodevelopfrom
dozreg-toplud wants to merge 4 commits intodevelopfrom
Conversation
Contributor
|
For blob storage, it'd be useful for automeld to drop all the caches so
that chop actually deletes blobs that have zero references left (assuming
the user runs |rm, |tomb on the blob first). Without dropping the ford
cache, a dangling reference from clay will remain, and blobs won't ever be
deleted.
…On Wed, Apr 29, 2026 at 10:51 AM Kirill Afonin ***@***.***> wrote:
@dozreg-toplud <https://github.com/dozreg-toplud> requested review from
@urbit/runtime <https://github.com/orgs/urbit/teams/runtime> on:
urbit/vere#1006 <#1006> meld: make
dropping memo/ford persistent tables optional as a code owner.
—
Reply to this email directly, view it on GitHub
<#1006 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DQRG4KS3ICRVMGZFO53L4YIQHVAVCNFSM6AAAAACYK7DV42VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRUHE4TQMJRGY2TONA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Contributor
Author
|
@matthew-levan ford caches would still be freed in all other occasions, like memory pressure. |
Contributor
Author
|
also adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds arguments to
u3_meld_allto control whether we free the persistent memoization buckets.Adds
memo-dropandford-dropCLI arguments to free the buckets (they are retained by default).Added argument parsing to
%meldtask: if an argument is a pair of loobeans then they are passed, otherwise fall back to not freeing the buckets.NB: On automeld we free the persistent memo bucket but not the ford caches. Thoughts?