test(hypervisors): add unit tests for Firecracker#625
Open
r0hansaxena wants to merge 1 commit intourunc-dev:mainfrom
Open
test(hypervisors): add unit tests for Firecracker#625r0hansaxena wants to merge 1 commit intourunc-dev:mainfrom
r0hansaxena wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Signed-off-by: r0hansaxena <rohansxn8772@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the Firecracker VMM backend, covering BuildExecCmd and the interface methods (UsesKVM, SupportsSharedfs, Path, Ok, PreExec). Tests verify the argv layout and the JSON config written to /tmp/fc.json, memory fallback, seccomp toggle, networking, drives with rootfs flagging, initrd path priority and the vsock device.
Related issues
How was this tested?
All 6 unit tests pass locally. Full package tests pass. Linter passes (make lint, 0 issues).
LLM usage
LLM was used to assist with writing the tests. All code was reviewed and tested locally before submission.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).