Skip to content

fix: time namespace validation#35

Open
imshubham22apr-gif wants to merge 1 commit intourunc-dev:mainfrom
imshubham22apr-gif:fix/issue-30
Open

fix: time namespace validation#35
imshubham22apr-gif wants to merge 1 commit intourunc-dev:mainfrom
imshubham22apr-gif:fix/issue-30

Conversation

@imshubham22apr-gif
Copy link
Copy Markdown

Added support for validating the time_for_children namespace in the E2E test suite. Previously, the TimeNamespace validation case was incorrectly using the UTS namespace map keys and error reporting. This change ensures that the unikernel's time namespace is correctly identified and compared against the host's time_for_children namespace, improving the accuracy of namespace isolation tests.

Related issues
Fixes #30
How was this tested?
This change was tested locally using a mock E2E environment on Windows:

Created a mock /proc structure with namespace symlinks.
Mocked the nerdctl binary to return container metadata.
Executed the E2E test suite with debug logging to verify that the time_for_children namespace IDs were correctly extracted and compared.
Verified that the test passes when the namespaces match.
LLM usage
Assisted only for local verification via environment mocking.

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

@abhaygoudannavar
Copy link
Copy Markdown

Hi @imshubham22apr-gif thanks for the PR but the issue is not yet reviewd or accepted so please wait until it gets accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

namespaceTest compares UTS namespace instead of time namespace for TimeNamespace case

2 participants