fix: time namespace validation#35
Open
imshubham22apr-gif wants to merge 1 commit intourunc-dev:mainfrom
Open
Conversation
|
Hi @imshubham22apr-gif thanks for the PR but the issue is not yet reviewd or accepted so please wait until it gets accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for validating the time_for_children namespace in the E2E test suite. Previously, the TimeNamespace validation case was incorrectly using the UTS namespace map keys and error reporting. This change ensures that the unikernel's time namespace is correctly identified and compared against the host's time_for_children namespace, improving the accuracy of namespace isolation tests.
Related issues
Fixes #30
How was this tested?
This change was tested locally using a mock E2E environment on Windows:
Created a mock /proc structure with namespace symlinks.
Mocked the nerdctl binary to return container metadata.
Executed the E2E test suite with debug logging to verify that the time_for_children namespace IDs were correctly extracted and compared.
Verified that the test passes when the namespaces match.
LLM usage
Assisted only for local verification via environment mocking.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).