fix: resolve FD leak and correct TimeNamespace validation#36
Open
imshubham22apr-gif wants to merge 1 commit intourunc-dev:mainfrom
Open
fix: resolve FD leak and correct TimeNamespace validation#36imshubham22apr-gif wants to merge 1 commit intourunc-dev:mainfrom
imshubham22apr-gif wants to merge 1 commit intourunc-dev:mainfrom
Conversation
|
Hi @imshubham22apr-gif thanks for the PR but the issue is not yet reviewd or accepted so please wait until it gets accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two critical issues in the e2e test suite:
findLineInFilefunction by ensuring the file is properly closed usingdefer file.Close().specs.TimeNamespace. Previously, the code was incorrectly performing autsnamespace comparison. Added support for readingtime_for_childrenfrom/procand updated the comparison logic to use the correct namespace map key.Related issues
How was this tested?
GOOS=linux GOARCH=amd64 go test -c ./tests/e2e.TimeNamespacecomparison logic using a standalone test script to ensure the correct map keys are accessed and the logic is reachable.LLM usage
Assisted for code analysis.
Checklist
make lint).