fix(cli): auto-pass --ignore-scripts when pnpm >=11 in migrate/create#1533
Merged
fix(cli): auto-pass --ignore-scripts when pnpm >=11 in migrate/create#1533
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
added
test: install-e2e
Graphite App
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.gh.lumenfield.work/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 20784c5. Configure here.
This was referenced May 8, 2026
pnpm v11 promoted ERR_PNPM_IGNORED_BUILDS from a warning to a hard exit-1 on unapproved build scripts. The auto-install run by `vp migrate` / `vp create` happens before the user has a chance to add packages to `pnpm.onlyBuiltDependencies`, so transitive deps like esbuild and @parcel/watcher fail the install — breaking the tanstack-start-helloworld and viteplus-ws-repro ecosystem-ci jobs. When the resolved package manager is pnpm and the version is >=11.0.0, inject `--ignore-scripts` into the auto-triggered install. User-invoked `vp install` is unchanged. The migrate early-return (eslint/prettier-only) path resolves a `latest` version through downloadPackageManager so the check applies there too.
cpojer
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm v11 promoted ERR_PNPM_IGNORED_BUILDS from a warning to a hard exit-1
on unapproved build scripts. The auto-install run by
vp migrate/vp createhappens before the user has a chance to add packages topnpm.onlyBuiltDependencies, so transitive deps like esbuild and@parcel/watcher fail the install — breaking the tanstack-start-helloworld
and viteplus-ws-repro ecosystem-ci jobs.
When the resolved package manager is pnpm and the version is >=11.0.0,
inject
--ignore-scriptsinto the auto-triggered install. User-invokedvp installis unchanged. The migrate early-return (eslint/prettier-only)path resolves a
latestversion through downloadPackageManager so thecheck applies there too.
Note
Medium Risk
Changes dependency installation behavior in
vp create/vp migrateby conditionally adding--ignore-scriptsfor pnpm v11+, which could mask legitimate install-script failures during the automated install step (though user-invoked installs remain unchanged).Overview
Fixes pnpm v11 auto-install failures during scaffolding/migration.
runViteInstallnow detects pnpm>=11and automatically appends--ignore-scriptsfor the auto-triggered install to avoidERR_PNPM_IGNORED_BUILDS.vp createandvp migratenow pass the resolved package manager + version intorunViteInstall, including the migrate “already Vite+” early-return path which resolves non-semver versions (e.g.latest) before deciding. Adds unit tests for the newshouldIgnoreScriptsForAutoInstallhelper.Reviewed by Cursor Bugbot for commit 20784c5. Configure here.